This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][NFC] Fix dependency type in AAUndefinedBehaviorImpl::updateImpl
ClosedPublic

Authored by okura on Aug 29 2020, 2:04 PM.

Diff Detail

Event Timeline

okura created this revision.Aug 29 2020, 2:04 PM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
okura requested review of this revision.Aug 29 2020, 2:04 PM
jdoerfert added inline comments.Aug 29 2020, 2:17 PM
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
2033

If we only use known values you don't even need to track the dependence. here and above.

2075–2076

clang-format the patch, also as above.

okura updated this revision to Diff 288821.Aug 29 2020, 6:12 PM
  • fix dependence
  • fix formatting
okura added inline comments.Aug 29 2020, 6:15 PM
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
2075–2076

Something was wrong with Automatic formatting, sorry.

jdoerfert accepted this revision.Aug 29 2020, 7:54 PM

LGTM. Make sure there are no test changes

This revision is now accepted and ready to land.Aug 29 2020, 7:54 PM