Page MenuHomePhabricator

[UpdateTestChecks] include { in function signature check line
ClosedPublic

Authored by sstefan1 on Aug 28 2020, 1:25 AM.

Details

Summary

After D85099, if we have attribute group in the function signature that hasn't
been seen before, and later a callsite with the same attribute group, filecheck will evaluate
the first attribute group to for example #0 {. We now include { in the args_and_sig group to avoid this.

Diff Detail

Event Timeline

sstefan1 created this revision.Aug 28 2020, 1:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2020, 1:25 AM
sstefan1 requested review of this revision.Aug 28 2020, 1:25 AM
sstefan1 edited the summary of this revision. (Show Details)Aug 28 2020, 1:26 AM
sstefan1 edited the summary of this revision. (Show Details)
jdoerfert accepted this revision.Aug 28 2020, 11:26 AM

LGTM, fix the clang tests but it should be trivial as the other test changes. thanks for taking care of this.

This revision is now accepted and ready to land.Aug 28 2020, 11:26 AM
This revision was landed with ongoing or failed builds.Aug 28 2020, 2:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2020, 2:45 PM