This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add check for tile clause restriction
ClosedPublic

Authored by clementval on Aug 26 2020, 1:01 PM.

Details

Summary

The tile clause in OpenACC 3.0 imposes some restriction. Element in the tile size list are either * or a
constant positive integer expression. If there are n tile sizes in the list, the loop construct must be immediately
followed by n tightly-nested loops.
This patch implement these restrictions and add some tests.

Diff Detail

Event Timeline

clementval created this revision.Aug 26 2020, 1:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2020, 1:01 PM
clementval requested review of this revision.Aug 26 2020, 1:01 PM
klausler accepted this revision.Aug 27 2020, 9:19 AM
klausler added inline comments.
flang/lib/Parser/openacc-parsers.cpp
134

This production in the comment does not match the production in the code.

141

Comment does not match the code.

This revision is now accepted and ready to land.Aug 27 2020, 9:19 AM
clementval marked 2 inline comments as done.

Rebase + address minor comments

clementval added inline comments.Aug 27 2020, 7:08 PM
flang/lib/Parser/openacc-parsers.cpp
134

Changed it to be an empty optional.

141

Changed it to be an empty optional.

This revision was landed with ongoing or failed builds.Aug 27 2020, 7:13 PM
This revision was automatically updated to reflect the committed changes.