This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Fix gang-argument parsing and add validity tests for !$acc loop
ClosedPublic

Authored by clementval on Aug 25 2020, 5:44 PM.

Details

Summary

This patch fix the prasing for the gang-arg values for the gang clause. It also adds
some clause validity tests for the loop construct.

Diff Detail

Event Timeline

clementval created this revision.Aug 25 2020, 5:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2020, 5:44 PM
clementval requested review of this revision.Aug 25 2020, 5:44 PM
klausler accepted this revision.Aug 27 2020, 9:24 AM
klausler added inline comments.
flang/lib/Parser/openacc-parsers.cpp
144

","_tok / "STATIC:"_tok >> can be written better as just ", STATIC" >>.

The production does not match the comment.

This revision is now accepted and ready to land.Aug 27 2020, 9:24 AM

Rebase + address minor comments

This revision was landed with ongoing or failed builds.Aug 27 2020, 7:33 PM
This revision was automatically updated to reflect the committed changes.