Page MenuHomePhabricator
Differential D86516

GlobalISel: Add combines for extend operations
ClosedPublic
Actions

Authored by volkan on Aug 25 2020, 3:22 AM.

Details

Reviewers
aditya_nandakumar
dsanders
mkitzan
arsenm
aemerson
paquette
Summary

Add various combines for G_ANYEXT, G_SEXT and G_ZEXT.

Diff Detail

Event Timeline

volkan created this revision.Aug 25 2020, 3:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2020, 3:22 AM
Herald added subscribers: kerbowa, hiraditya, rovka and 2 others. · View Herald Transcript
volkan requested review of this revision.Aug 25 2020, 3:22 AM
Herald added a subscriber: wdng. · View Herald TranscriptAug 25 2020, 3:22 AM
Harbormaster completed remote builds in B69422: Diff 287610.Aug 25 2020, 4:00 AM
arsenm added a comment.Aug 27 2020, 6:31 AM

Can you add some tests with vectors?

volkan updated this revision to Diff 288991.Aug 31 2020, 11:05 AM
  • Added vector tests.
arsenm added inline comments.Aug 31 2020, 12:44 PM
llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
1759–1760

setInstrAndDebugLoc?

Why build a copy instead of CombinerHelper::replaceRegWith?

1811

setInstrAndDebugLoc?

volkan updated this revision to Diff 289015.Aug 31 2020, 1:18 PM
  • Use setInstrAndDebugLoc .
  • Use replaceRegWith to replace registers.
volkan marked 2 inline comments as done.Aug 31 2020, 1:19 PM
arsenm accepted this revision.Sep 1 2020, 6:07 AM
This revision is now accepted and ready to land.Sep 1 2020, 6:07 AM
volkan mentioned this in rG061182b7baf8: GlobalISel: Add combines for extend operations.Sep 1 2020, 8:50 AM
volkan closed this revision.Sep 1 2020, 8:51 AM

Committed in https://github.com/llvm/llvm-project/commit/061182b7baf879badc9ff82c88d383d2d9ce279b.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
CodeGen/
GlobalISel/
10 lines
Target/
GlobalISel/
23 lines
lib/
CodeGen/
GlobalISel/
72 lines
test/
CodeGen/
AArch64/
GlobalISel/
196 lines
5 lines
AMDGPU/
GlobalISel/
16 lines
6 lines

Diff 289015

View Options

llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h

Loading...
View Options

llvm/include/llvm/Target/GlobalISel/Combine.td

Loading...
View Options

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

Loading...
View Options

llvm/test/CodeGen/AArch64/GlobalISel/combine-ext.mir

Loading...
View Options

llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-extending-loads-s1.mir

Loading...
View Options

llvm/test/CodeGen/AMDGPU/GlobalISel/combine-amdgpu-cvt-f32-ubyte.mir

Loading...
View Options

llvm/test/CodeGen/AMDGPU/GlobalISel/combine-shl-from-extend-narrow.prelegal.mir

Loading...