This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Remove TOOLCHAIN_TOOLS specialization
ClosedPublic

Authored by smeenai on Aug 21 2020, 1:10 PM.

Details

Summary

{builtin,runtime}_register_target passes a TOOLCHAIN_TOOLS list, whereas
{builtin,runtime}_default_target does notl. The explicit TOOLCHAIN_TOOLS
list matches what LLVMExternalProjectUtils would have set anyway,
barring some target-specific adjustments, and those target-specific
adjustments seem valuable, so let's drop the explicit TOOLCHAIN_TOOLS
list and let LLVMExternalProjectUtils take care of it.

Diff Detail

Event Timeline

smeenai created this revision.Aug 21 2020, 1:10 PM
smeenai requested review of this revision.Aug 21 2020, 1:10 PM
phosek accepted this revision.Aug 21 2020, 1:29 PM

LGTM

This revision is now accepted and ready to land.Aug 21 2020, 1:29 PM
This revision was automatically updated to reflect the committed changes.