This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Use different technique for sample v3s16 values
ClosedPublic

Authored by arsenm on Aug 20 2020, 3:56 PM.

Details

Summary

Avoid relying on implicit_def values, and odd sized G_INSERT/G_EXTRACT

Diff Detail

Event Timeline

arsenm created this revision.Aug 20 2020, 3:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2020, 3:56 PM
arsenm requested review of this revision.Aug 20 2020, 3:56 PM
foad added inline comments.Aug 21 2020, 1:11 AM
llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-intrinsic-round.mir
894–926

It looks like you lost all the CHECK: lines on this and a bunch of other tests.

arsenm updated this revision to Diff 287056.Aug 21 2020, 9:50 AM

Fix some missing checks

foad accepted this revision.Aug 24 2020, 1:16 AM
This revision is now accepted and ready to land.Aug 24 2020, 1:16 AM