This commit makes FileCheck print all CHECK-NOT directive failure in a
CHECK-NOT block even if one fails. Prior to that, it would stop trying
to match CHECK-NOT directive as soon as one in the block fails.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/test/FileCheck/multiple-check-not-failures.txt | ||
---|---|---|
3 | ||
5–6 | I prefer this style - it means each line clearly indicates the continuation pattern individually, whilst also showing that the entire command is present in the first line (which the existing style doesn't). | |
32 | I think this line is a little too precise for a -NOT pattern - a slight change to the message would result in the check no longer doing anything useful. You could probably just get away with something like CHECK-ERRORS-NOT: error: |
Address review comments
llvm/test/FileCheck/multiple-check-not-failures.txt | ||
---|---|---|
32 | I had to disable --dump-input for that because otherwise it shows the error again and the CHECK-NOT fails. |