Page MenuHomePhabricator

[MLIR][SPIRVToLLVM] Updated the documentation for the conversion
ClosedPublic

Authored by georgemitenkov on Aug 20 2020, 7:09 AM.

Details

Summary

This patch updates the SPIR-V to LLVM conversion manual.
Particularly, the following sections are added:

  • spv.EntryPoint/spv.ExecutionMode handling
  • Mapping for spv.AccessChain
  • Change in allowed storage classes for spv.globalVariable
  • Change of the runner section name

Diff Detail

Event Timeline

georgemitenkov created this revision.Aug 20 2020, 7:09 AM
georgemitenkov requested review of this revision.Aug 20 2020, 7:09 AM
mravishankar requested changes to this revision.Aug 20 2020, 9:44 AM
mravishankar added inline comments.
mlir/docs/SPIRVToLLVMDialectConversion.md
368–369

I think the last statement can be dropped.

475–477

Dont see how this is related to multithreading?

This revision now requires changes to proceed.Aug 20 2020, 9:44 AM
georgemitenkov marked 2 inline comments as done.

Addressed comments.

mravishankar accepted this revision.Aug 21 2020, 9:43 AM
This revision is now accepted and ready to land.Aug 21 2020, 9:43 AM