This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Use unmerge instead of extract in addrspace queries
ClosedPublic

Authored by arsenm on Aug 19 2020, 1:50 PM.

Details

Summary

This is a bit more consistent the regular operation legalization.

Diff Detail

Event Timeline

arsenm created this revision.Aug 19 2020, 1:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2020, 1:50 PM
arsenm requested review of this revision.Aug 19 2020, 1:50 PM
foad accepted this revision.Aug 19 2020, 1:56 PM

Looks obvious, but aren't there any tests that show the legalized GMIR for this case?

This revision is now accepted and ready to land.Aug 19 2020, 1:56 PM

Looks obvious, but aren't there any tests that show the legalized GMIR for this case?

The only test for it goes to the ISA, and doesn't produce an observable change there