Page MenuHomePhabricator

Fix an issue where get_system_libname creates an empty regex capture on windows
ClosedPublic

Authored by haampie on Aug 19 2020, 1:39 PM.

Diff Detail

Event Timeline

haampie created this revision.Aug 19 2020, 1:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2020, 1:39 PM
haampie requested review of this revision.Aug 19 2020, 1:39 PM

Just tested this out, yes it fixes the issue thanks!
Although I'm not at all familiar with CMake, so somebody else should probably review.

phosek accepted this revision.Aug 19 2020, 2:32 PM

LGTM

This revision is now accepted and ready to land.Aug 19 2020, 2:32 PM