Page MenuHomePhabricator

haampie (Harmen Stoppels)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 12 2020, 12:14 AM (11 w, 3 d)

Recent Activity

Sep 15 2020

haampie added a comment to D87590: Backport D79219, D85820, D86134 to 10.0 branch.

Also note that the changes are not likely to be backported to 11 even: https://reviews.llvm.org/rG31e5f7120bdd2f76337686d9d169b1c00e6ee69c#942622.

Sep 15 2020, 4:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
haampie added a comment to D87590: Backport D79219, D85820, D86134 to 10.0 branch.

D86134 should not be added, it was reverted afterwards. What eventually landed was D85820, which adds a better fix for what D86134 was supposed to solve.

Sep 15 2020, 4:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 30 2020

haampie updated the diff for D85820: Use find_library for ncurses.

Another take on this isuse, incorporating @phosek's comment on making find_library not find shared libs when compiling with LLVM_BUILD_STATIC=ON, and making sure that get_system_libname does not add empty items to a regex capture group, as CMake's regex engine does not support this.

Aug 30 2020, 11:57 AM · Restricted Project, Restricted Project, Restricted Project

Aug 27 2020

haampie added a comment to D86521: Revert "Use find_library for ncurses".

@phosek it would be great to get that patch in, but the truth is it is difficult testing across multiple platforms for me; I can only test on Linux and macOS, not Windows (GNU). Since that patch would touch predefined, platform-dependent cmake variables, I would want to test it properly before submitting a patch, which might take a bit more time. So for me it would be best to temporarily accept this reverting patch, and submit a properly tested patch afterwards.

Aug 27 2020, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2020

haampie added a reverting change for rGa52173a3e565: Use find_library for ncurses: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM
haampie added a reverting change for rG495f91fd33d4: [CMake] Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM
haampie added a reverting change for rG8e4acb82f71a: [CMake] Fix OCaml build failure because of absolute path in system libs: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM
haampie added a reverting change for rG76bf26236f6f: [CMake] Always mark terminfo as unavailable on Windows: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM
haampie added a reverting change for D86173: Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM · Restricted Project, Restricted Project
haampie requested review of D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM · Restricted Project, Restricted Project, Restricted Project
haampie added a reverting change for D86234: [CMake] Always mark terminfo as unavailable on Windows: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM · Restricted Project
haampie added a reverting change for D86134: Fix OCaml build failure because of absolute path in system libs: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM · Restricted Project
haampie added a reverting change for D86245: Fix an issue where get_system_libname creates an empty regex capture on windows: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM · Restricted Project
haampie added a reverting change for rG1ed1e16ab83f: [CMake] Fix an issue where get_system_libname creates an empty regex capture on…: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM
haampie added a reverting change for D85820: Use find_library for ncurses: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM · Restricted Project, Restricted Project, Restricted Project
haampie added a reverting change for rG34fe9613dda3: Fix msan build: D86521: Revert "Use find_library for ncurses".
Aug 25 2020, 3:58 AM
haampie added a comment to D85820: Use find_library for ncurses.

@gkistanova It's true that this change has lead to more issues I could ever imagine, but I think the link you provided is the last remaining problem.

Aug 25 2020, 1:22 AM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2020

haampie added a comment to D86434: Fix ncurses/zlib in LLVM_SYSTEM_LIBS for Windows GNU.

@mati865 can you test this on your platform? You only have to run cmake ../llvm and check whether tools/llvm-config/BuildVariables.inc: has a proper #define LLVM_SYSTEM_LIBS "-lrt -ldl -lpthread -lm -lz -ltinfo"

Aug 24 2020, 1:36 AM · Restricted Project
haampie requested review of D86434: Fix ncurses/zlib in LLVM_SYSTEM_LIBS for Windows GNU.
Aug 24 2020, 1:34 AM · Restricted Project

Aug 21 2020

haampie added a comment to rG31e5f7120bdd: [CMake] Simplify CMake handling for zlib.

@phosek do you know what is required to backport this as well as the ncurses detection to the LLVM 11 release branch?

Aug 21 2020, 8:30 AM

Aug 19 2020

haampie added a comment to D86134: Fix OCaml build failure because of absolute path in system libs.

@aeubanks and @phosek: see https://reviews.llvm.org/D86245 for a last fix that checks whether CMAKE_FIND_LIBRARY_PREFIXES and CMAKE_FIND_LIBRARY_SUFFIXES are non-empty before applying the regex to fix this window issue

Aug 19 2020, 1:48 PM · Restricted Project
haampie requested review of D86245: Fix an issue where get_system_libname creates an empty regex capture on windows.
Aug 19 2020, 1:39 PM · Restricted Project
haampie added a comment to D85820: Use find_library for ncurses.

@gribozavr2: can you try https://reviews.llvm.org/D86134? It should fix your issue, as well as the same issue w.r.t. the ZLIB changes of https://reviews.llvm.org/D79219 on macOS.

Aug 19 2020, 3:57 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2020

haampie updated the diff for D86134: Fix OCaml build failure because of absolute path in system libs.

Move the output variable to the end and use lowercase for arguments.

Aug 18 2020, 3:53 PM · Restricted Project
haampie added a comment to D85820: Use find_library for ncurses.

@srj could you please try / review https://reviews.llvm.org/D86173 for a fix for your problem?

Aug 18 2020, 3:14 PM · Restricted Project, Restricted Project, Restricted Project
haampie added inline comments to D79219: [CMake] Simplify CMake handling for zlib.
Aug 18 2020, 3:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
haampie requested review of D86173: Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF.
Aug 18 2020, 3:02 PM · Restricted Project, Restricted Project
haampie added inline comments to D85820: Use find_library for ncurses.
Aug 18 2020, 2:47 PM · Restricted Project, Restricted Project, Restricted Project
haampie updated the summary of D86134: Fix OCaml build failure because of absolute path in system libs.
Aug 18 2020, 4:40 AM · Restricted Project
haampie added a reviewer for D86134: Fix OCaml build failure because of absolute path in system libs: RKSimon.
Aug 18 2020, 4:38 AM · Restricted Project
haampie requested review of D86134: Fix OCaml build failure because of absolute path in system libs.
Aug 18 2020, 4:37 AM · Restricted Project

Aug 17 2020

haampie added a comment to D85820: Use find_library for ncurses.

Let me know if you need me to land this for you.

Aug 17 2020, 11:30 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2020

haampie updated the diff for D85820: Use find_library for ncurses.

DRY in find_library

Aug 16 2020, 12:41 AM · Restricted Project, Restricted Project, Restricted Project

Aug 14 2020

haampie updated the diff for D85820: Use find_library for ncurses.

use REQUIRED when FORCE_ON

Aug 14 2020, 2:09 AM · Restricted Project, Restricted Project, Restricted Project

Aug 13 2020

haampie added inline comments to D85820: Use find_library for ncurses.
Aug 13 2020, 3:42 AM · Restricted Project, Restricted Project, Restricted Project
haampie updated the diff for D85820: Use find_library for ncurses.

Use LLVM_ENABLE_TERMINFO and make it respect FORCE_ON.

Aug 13 2020, 3:19 AM · Restricted Project, Restricted Project, Restricted Project

Aug 12 2020

haampie added a comment to D85820: Use find_library for ncurses.

I also considered set(CURSES_NEED_NCURSES true) and then find_package(Curses), but indeed CURSES_LIBRARIES is the only thing to work with, which lists too many libraries. I think find_library is cleanest. Thanks for the LLVM_ENABLE_TERMINFO, I can add that change.

Aug 12 2020, 2:59 PM · Restricted Project, Restricted Project, Restricted Project
haampie added inline comments to D85820: Use find_library for ncurses.
Aug 12 2020, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
haampie updated the diff for D85820: Use find_library for ncurses.

Simplified detection a bit

Aug 12 2020, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
haampie updated the summary of D85820: Use find_library for ncurses.
Aug 12 2020, 2:09 AM · Restricted Project, Restricted Project, Restricted Project
haampie requested review of D85820: Use find_library for ncurses.
Aug 12 2020, 2:00 AM · Restricted Project, Restricted Project, Restricted Project
haampie added a comment to D79219: [CMake] Simplify CMake handling for zlib.

Great, one benefit of this is that zlib can now be detected in non-system libs. Maybe we should handle ncurses / TERMINFO in a similar manner? It currently has similar logic as finding zlib had

Aug 12 2020, 1:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project