Page MenuHomePhabricator

Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF
ClosedPublic

Authored by haampie on Aug 18 2020, 3:02 PM.

Details

Summary

https://reviews.llvm.org/D85820 introduced a bug where LLVM_ENABLE_TERMINFO was set to true when the library was found, even when the user had set -DLLVM_ENABLE_TERMINFO=OFF.

Diff Detail

Event Timeline

haampie created this revision.Aug 18 2020, 3:02 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 18 2020, 3:02 PM
Herald added subscribers: llvm-commits, Restricted Project, mgorny. · View Herald Transcript
haampie requested review of this revision.Aug 18 2020, 3:02 PM
phosek accepted this revision.Aug 18 2020, 3:15 PM

LGTM

This revision is now accepted and ready to land.Aug 18 2020, 3:15 PM
srj added a comment.Aug 18 2020, 4:38 PM

Thanks. this fixes the issues I had with https://reviews.llvm.org/D85820 and Halide. LGTM.

This revision was landed with ongoing or failed builds.Aug 19 2020, 10:31 AM
This revision was automatically updated to reflect the committed changes.