Page MenuHomePhabricator

[mlir] VectorToSCF bug in setAllocAtFunctionEntry fixed.
ClosedPublic

Authored by limo1996 on Aug 17 2020, 9:10 AM.

Details

Summary

The function makes too strong assumption regarding parent FuncOp
which gets broken when FuncOp is first lowered to llvm function.
In this fix we generalize the assumption to allocation scope and
add assertion to produce user friendly message in case our assumption
is broken.

Diff Detail

Event Timeline

limo1996 created this revision.Aug 17 2020, 9:10 AM
Herald added a project: Restricted Project. · View Herald Transcript
limo1996 requested review of this revision.Aug 17 2020, 9:10 AM
ftynse accepted this revision.Aug 17 2020, 9:19 AM
This revision is now accepted and ready to land.Aug 17 2020, 9:19 AM
This revision was automatically updated to reflect the committed changes.