This is an archive of the discontinued LLVM Phabricator instance.

Differential D85972

[AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX
ClosedPublic

Authored by daltenty on Aug 14 2020, 6:55 AM.

Details

Reviewers
cebowleratibm
hubert.reinterpretcast
sfertile
jasonliu
Commits
rGf8454d60b829: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require…
Summary

since __int128 currently isn't supported on AIX.

Diff Detail

Event Timeline

daltenty created this revision.Aug 14 2020, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2020, 6:55 AM
Herald added subscribers: Restricted Project, mgorny, dberris. · View Herald Transcript
daltenty requested review of this revision.Aug 14 2020, 6:55 AM
daltenty retitled this revision from [AIX][compiler-rt] Don't add ppc builtin implementations that require __int128 on AIX to [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.Aug 14 2020, 6:58 AM
daltenty added reviewers: cebowleratibm, hubert.reinterpretcast, sfertile, jasonliu.
daltenty removed a project: Restricted Project.
daltenty removed a subscriber: Restricted Project.
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2020, 6:58 AM
daltenty updated this revision to Diff 285646.Aug 14 2020, 6:59 AM
  • Fix comment.
Harbormaster completed remote builds in B68410: Diff 285646.Aug 14 2020, 7:24 AM
Harbormaster completed remote builds in B68408: Diff 285643.Aug 14 2020, 7:26 AM
hubert.reinterpretcast accepted this revision.Aug 20 2020, 9:04 AM

LGTM with minor comment.

compiler-rt/lib/builtins/CMakeLists.txt
570–572

Restore alphabetical ordering of the separated list items.

This revision is now accepted and ready to land.Aug 20 2020, 9:04 AM
Closed by commit rGf8454d60b829: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require… (authored by daltenty). · Explain WhyAug 25 2020, 8:35 AM
This revision was automatically updated to reflect the committed changes.
daltenty added a commit: rGf8454d60b829: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require….

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
12 lines

Diff 285643

compiler-rt/lib/builtins/CMakeLists.txt

Show First 20 Lines • Show All 547 Lines • ▼ Show 20 Lines
set(mipsel_SOURCES ${mips_SOURCES}) set(mipsel_SOURCES ${mips_SOURCES})
set(mips64_SOURCES ${GENERIC_TF_SOURCES} set(mips64_SOURCES ${GENERIC_TF_SOURCES}
${mips_SOURCES}) ${mips_SOURCES})
set(mips64el_SOURCES ${GENERIC_TF_SOURCES} set(mips64el_SOURCES ${GENERIC_TF_SOURCES}
${mips_SOURCES}) ${mips_SOURCES})
set(powerpc64_SOURCES set(powerpc64_SOURCES
ppc/divtc3.c ppc/divtc3.c
ppc/fixtfti.c
ppc/fixtfdi.c ppc/fixtfdi.c
ppc/fixunstfti.c
ppc/fixunstfdi.c ppc/fixunstfdi.c
ppc/floattitf.c
ppc/floatditf.c ppc/floatditf.c
ppc/floatunditf.c ppc/floatunditf.c
ppc/gcc_qadd.c ppc/gcc_qadd.c
ppc/gcc_qdiv.c ppc/gcc_qdiv.c
ppc/gcc_qmul.c ppc/gcc_qmul.c
ppc/gcc_qsub.c ppc/gcc_qsub.c
ppc/multc3.c ppc/multc3.c
${GENERIC_SOURCES} ${GENERIC_SOURCES}
) )
# These routines require __int128, whic isn't supported on AIX.
if (NOT ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
set(powerpc64_SOURCES
ppc/floattitf.c
ppc/fixtfti.c
ppc/fixunstfti.c
hubert.reinterpretcastUnsubmitted
Not Done
ReplyInline Actions
set(powerpc64_SOURCES
- ppc/floattitf.c
ppc/fixtfti.c
ppc/fixunstfti.c
+ ppc/floattitf.c
${powerpc64_SOURCES}

Restore alphabetical ordering of the separated list items.

hubert.reinterpretcast: Restore alphabetical ordering of the separated list items.
${powerpc64_SOURCES}
)
endif()
set(powerpc64le_SOURCES ${powerpc64_SOURCES}) set(powerpc64le_SOURCES ${powerpc64_SOURCES})
set(riscv_SOURCES ${GENERIC_SOURCES} ${GENERIC_TF_SOURCES}) set(riscv_SOURCES ${GENERIC_SOURCES} ${GENERIC_TF_SOURCES})
set(riscv32_SOURCES set(riscv32_SOURCES
riscv/mulsi3.S riscv/mulsi3.S
${riscv_SOURCES} ${riscv_SOURCES}
) )
set(riscv64_SOURCES ${riscv_SOURCES}) set(riscv64_SOURCES ${riscv_SOURCES})
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines