This is an archive of the discontinued LLVM Phabricator instance.

Differential D85936

[InterfaceStub] Remove unnecessary include dir from llvm/lib/InterfaceStub/CMakeLists.txt
ClosedPublic

Authored by haowei on Aug 13 2020, 2:28 PM.

Details

Reviewers
thakis
phosek
leonardchan
Commits
rGee5d07e6ce89: Remove unnecessary HEADER_DIRS in lib/InterfaceStub/CMakeLists.txt
Summary

This change removes "${LLVM_MAIN_INCLUDE_DIR}/llvm/InterfaceStub" from llvm/lib/InterfaceStub/CMakeLists.txt as it is not necessary.

Diff Detail

Event Timeline

haowei created this revision.Aug 13 2020, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 2:28 PM
Herald added subscribers: llvm-commits, hiraditya, mgorny. · View Herald Transcript
haowei requested review of this revision.Aug 13 2020, 2:28 PM
haowei mentioned this in D85678: [elfabi] Move elfabi related code to InterfaceStub library.
phosek accepted this revision.Aug 13 2020, 2:53 PM

LGTM

This revision is now accepted and ready to land.Aug 13 2020, 2:53 PM
Harbormaster completed remote builds in B68333: Diff 285498.Aug 13 2020, 3:13 PM
Closed by commit rGee5d07e6ce89: Remove unnecessary HEADER_DIRS in lib/InterfaceStub/CMakeLists.txt (authored by haowei). · Explain WhyAug 14 2020, 11:23 AM
This revision was automatically updated to reflect the committed changes.
haowei added a commit: rGee5d07e6ce89: Remove unnecessary HEADER_DIRS in lib/InterfaceStub/CMakeLists.txt.

Revision Contents

PathSize
llvm/
lib/
InterfaceStub/
3 lines

Diff 285498

llvm/lib/InterfaceStub/CMakeLists.txt

add_llvm_component_library(LLVMInterfaceStub add_llvm_component_library(LLVMInterfaceStub
ELFObjHandler.cpp ELFObjHandler.cpp
ELFStub.cpp ELFStub.cpp
TBEHandler.cpp TBEHandler.cpp
ADDITIONAL_HEADER_DIRS
"${LLVM_MAIN_INCLUDE_DIR}/llvm/InterfaceStub"
) )