Page MenuHomePhabricator

[DWARFYAML] Replace InitialLength with Format and Length. NFC.
ClosedPublic

Authored by Higuoxing on Aug 12 2020, 11:42 PM.

Details

Summary

This change replaces the InitialLength of pub-tables with Format and
Length. All the InitialLength fields have been removed.

Diff Detail

Event Timeline

Higuoxing created this revision.Aug 12 2020, 11:42 PM
Herald added a project: Restricted Project. · View Herald Transcript
Higuoxing requested review of this revision.Aug 12 2020, 11:42 PM

Nice! Do we have/need any DWARF64 testing for the pubnames etc tables?

Higuoxing updated this revision to Diff 285290.Aug 13 2020, 2:23 AM

Test DWARF64 pub-tables.

Nice! Do we have/need any DWARF64 testing for the pubnames etc tables?

Originally, yaml2obj doesn't support emitting DWARF64 pub-tables. I've slightly modified the DWARF emitter and added a bunch of tests. I'm afraid it will bring difficulty in reviewing this change. Shall I add them in a separate patch?

Nice! Do we have/need any DWARF64 testing for the pubnames etc tables?

Originally, yaml2obj doesn't support emitting DWARF64 pub-tables. I've slightly modified the DWARF emitter and added a bunch of tests. I'm afraid it will bring difficulty in reviewing this change. Shall I add them in a separate patch?

Ah, I didn't realise it didn't support it. Let's split off support to a separate patch.

Higuoxing updated this revision to Diff 285302.Aug 13 2020, 3:12 AM

Revert to previous version.

Higuoxing updated this revision to Diff 285304.Aug 13 2020, 3:14 AM

Revert changes in DWARFEmitter.cpp

This revision is now accepted and ready to land.Aug 13 2020, 3:35 AM
This revision was landed with ongoing or failed builds.Aug 13 2020, 3:39 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B68237: Diff 285304.