Page MenuHomePhabricator

[DWARFYAML] Make the address size of compilation units optional.
ClosedPublic

Authored by Higuoxing on Aug 11 2020, 7:57 PM.

Details

Summary

This patch makes the 'AddrSize' field optional. If the address size is
missing, yaml2obj will infer it from the object file.

Diff Detail

Event Timeline

Higuoxing created this revision.Aug 11 2020, 7:57 PM
Herald added a project: Restricted Project. · View Herald Transcript
Higuoxing requested review of this revision.Aug 11 2020, 7:57 PM

Perhaps, you should be able to simplify some other test cases too with this change? I.e. to remove the 'AddrSize' field?

Perhaps, you should be able to simplify some other test cases too with this change? I.e. to remove the 'AddrSize' field?

Thanks! I will do it. Shall I simplify them in this change?

Perhaps, you should be able to simplify some other test cases too with this change? I.e. to remove the 'AddrSize' field?

Thanks! I will do it. Shall I simplify them in this change?

Yes, I think it is fine to do it in this change - when we introduce some functionality that simplifies things it is often reasonable to
apply it to the same patch to demostrate how much it is usable/useful.

Code change looks good. Thanks. I'll hold off approving until you've made any test changes too.

Higuoxing updated this revision to Diff 285062.Aug 12 2020, 6:19 AM

Simplify some tests to get rid of 'AddrSize' fields.

This revision is now accepted and ready to land.Aug 12 2020, 6:33 AM
This revision was landed with ongoing or failed builds.Aug 12 2020, 6:48 AM
This revision was automatically updated to reflect the committed changes.