Page MenuHomePhabricator

[DWARFYAML] Let the address size of line tables inferred from the object file.
ClosedPublic

Authored by Higuoxing on Aug 10 2020, 11:06 PM.

Details

Summary

Currently, the line table uses the first compilation unit's address size
as its address size. It's not the right behavior. The address size should be
inferred from the target machine.

Diff Detail

Event Timeline

Higuoxing created this revision.Aug 10 2020, 11:06 PM
Herald added a project: Restricted Project. · View Herald Transcript
Higuoxing requested review of this revision.Aug 10 2020, 11:06 PM
Higuoxing planned changes to this revision.Aug 11 2020, 3:54 AM
Higuoxing updated this revision to Diff 284669.Aug 11 2020, 5:15 AM

The address size shouldn't be referenced from the .debug_info section.

Higuoxing edited the summary of this revision. (Show Details)Aug 11 2020, 5:16 AM
jhenderson accepted this revision.Aug 11 2020, 5:40 AM

LGTM.

llvm/lib/ObjectYAML/DWARFEmitter.cpp
474–476
This revision is now accepted and ready to land.Aug 11 2020, 5:40 AM
Higuoxing updated this revision to Diff 284721.Aug 11 2020, 7:43 AM
Higuoxing marked an inline comment as done.

Address comments.

This revision was landed with ongoing or failed builds.Aug 11 2020, 7:46 AM
This revision was automatically updated to reflect the committed changes.