Page MenuHomePhabricator

[MLIR][NFC] Fix misleading diagnostic error + clang-tidy fix
ClosedPublic

Authored by bondhugula on Aug 8 2020, 2:51 PM.

Details

Summary

Fix misleading diagnostic error in affine.yield verifier + a clang-tidy fix.

Diff Detail

Event Timeline

bondhugula created this revision.Aug 8 2020, 2:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2020, 2:51 PM
bondhugula requested review of this revision.Aug 8 2020, 2:51 PM
rriddle accepted this revision.Aug 8 2020, 3:06 PM

Do we not have a test for this?

This revision is now accepted and ready to land.Aug 8 2020, 3:06 PM

Do we not have a test for this?

Yes, we unfortunately don't have one for this. I thought of adding one but found it wasn't that useful. Can add it if you think otherwise.

flaub added a comment.Aug 9 2020, 6:03 PM

LGTM, thanks!