Page MenuHomePhabricator

[OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator for map clause
ClosedPublic

Authored by cchen on Aug 7 2020, 3:50 PM.

Details

Summary

LValue map checker should handle CXXOperatorCallExpr

Diff Detail

Event Timeline

cchen created this revision.Aug 7 2020, 3:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2020, 3:50 PM
cchen requested review of this revision.Aug 7 2020, 3:50 PM
jdoerfert accepted this revision.Aug 7 2020, 3:54 PM

LGTM. Thanks for the quick turnaround time!

Nit: We usually avoid the - between PR and the number (your commit message). I guess that makes it easier to copy it into llvm.org/PRXXXXX and go to the bug.

This revision is now accepted and ready to land.Aug 7 2020, 3:54 PM
cchen updated this revision to Diff 284082.Aug 7 2020, 3:56 PM

Fix commit message

cchen retitled this revision from [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause to [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator for map clause.Aug 7 2020, 3:57 PM
This revision was landed with ongoing or failed builds.Aug 7 2020, 4:08 PM
This revision was automatically updated to reflect the committed changes.