This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][test] XFAIL two tests on 32-bit sparc
ClosedPublic

Authored by ro on Aug 5 2020, 12:32 PM.

Details

Summary

Two tests FAIL on 32-bit sparc:

Profile-sparc :: Posix/instrprof-gcov-parallel.test
UBSan-Standalone-sparc :: TestCases/Float/cast-overflow.cpp

The failure mode is similar:

Undefined                       first referenced
 symbol                             in file
__atomic_store_4                    /var/tmp/instrprof-gcov-parallel-6afe8d.o
__atomic_load_4                     /var/tmp/instrprof-gcov-parallel-6afe8d.o

Undefined                       first referenced
 symbol                             in file
__atomic_load_1                     /var/tmp/cast-overflow-72a808.o

This is a known bug: clang doesn't inline atomics on 32-bit sparc, unlike gcc.

The patch therefore XFAILs the tests.

Tested on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11.

Diff Detail

Event Timeline

ro created this revision.Aug 5 2020, 12:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2020, 12:32 PM
Herald added subscribers: Restricted Project, jfb, fedor.sergeev and 2 others. · View Herald Transcript
ro requested review of this revision.Aug 5 2020, 12:32 PM
ro added a comment.Aug 11 2020, 10:23 PM

Ping? It's been a week.

ro added a comment.Aug 13 2020, 1:11 AM

Ping? It's been a week.

ro added a comment.Aug 18 2020, 1:02 AM

Ping? Two weeks now.

vitalybuka accepted this revision.Aug 18 2020, 1:13 AM
vitalybuka removed reviewers: samsonov, marco-c, alekseyshl.
vitalybuka added a subscriber: vitalybuka.

At least 3 of selected reviewer are not active recently.

This revision is now accepted and ready to land.Aug 18 2020, 1:13 AM
This revision was automatically updated to reflect the committed changes.
ro added a comment.Aug 18 2020, 2:36 AM

At least 3 of selected reviewer are not active recently.

I see. I've sometimes found selecting suitable reviewers almost as hard as developing the patch ;-)

Thanks for the review.