calixte (calixte)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2018, 8:06 AM (9 w, 2 d)

Recent Activity

Fri, Sep 21

calixte committed rCRT342718: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
[profile] Fix the tests for patch in https://reviews.llvm.org/D49916.
Fri, Sep 21, 2:19 AM
calixte committed rL342718: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
[profile] Fix the tests for patch in https://reviews.llvm.org/D49916.
Fri, Sep 21, 2:19 AM
calixte closed D49917: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
Fri, Sep 21, 2:18 AM
calixte committed rL342717: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
[CodeGen] Add to emitted DebugLoc information about coverage when it's required
Fri, Sep 21, 2:18 AM
calixte committed rC342717: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
[CodeGen] Add to emitted DebugLoc information about coverage when it's required
Fri, Sep 21, 2:18 AM
calixte closed D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
Fri, Sep 21, 2:18 AM
calixte updated the diff for D49917: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..

Fix the tests.

Fri, Sep 21, 1:58 AM
calixte added inline comments to D49917: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
Fri, Sep 21, 1:58 AM

Thu, Sep 20

calixte added a comment to rL342678: [Bitcode] Address backwards compat bug in r342631.

Your patch looks good to me: I did the same in BitcodeReader.cpp::3518: bool isImplicitCode = Record.size() == 5 && Record[4];
to avoid the same kind of issue with a test in llvm which reads an old file.

Thu, Sep 20, 12:11 PM
calixte committed rL342661: [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm..
[profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.
Thu, Sep 20, 9:24 AM
calixte committed rCRT342661: [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm..
[profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.
Thu, Sep 20, 9:24 AM
calixte closed D49721: [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.org/D49659).
Thu, Sep 20, 9:24 AM
calixte committed rL342657: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.
[gcov] Fix wrong line hit counts when multiple blocks are on the same line
Thu, Sep 20, 9:11 AM
calixte closed D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.
Thu, Sep 20, 9:11 AM
calixte added a comment to D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.

I collected 2808 gcda (over 3211 gcno) from firefox build and ran "llvm-cov gcov" on each of them and no crash at all.

Thu, Sep 20, 8:41 AM
calixte updated the diff for D49721: [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.org/D49659).
  • Tests for switch statement have already been fixed
Thu, Sep 20, 4:59 AM
calixte committed rL342631: [IR] Add a boolean field in DILocation to know if a line must covered or not.
[IR] Add a boolean field in DILocation to know if a line must covered or not
Thu, Sep 20, 1:54 AM
calixte closed D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
Thu, Sep 20, 1:54 AM · debug-info
calixte updated the diff for D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
  • Fix .bc for test
Thu, Sep 20, 1:53 AM · debug-info

Wed, Sep 19

calixte committed rL342538: Verify commit access in fixing typo.
Verify commit access in fixing typo
Wed, Sep 19, 4:29 AM

Tue, Sep 18

calixte updated the diff for D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
  • Update test DILocation-implicit-code.ll
Tue, Sep 18, 11:58 AM · debug-info
calixte updated the diff for D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
  • Add a test: test/Bitcode/DILocation-implicit-code.ll
  • and update: test/Assembler/dilocation.ll
  • fix layout issue with MSVC
  • fix the doc
Tue, Sep 18, 11:00 AM · debug-info

Sat, Sep 15

calixte updated the diff for D52033: [GCOV] Add options to filter files which must be instrumented..

Fix stupid error when checking the returned value of real_path

Sat, Sep 15, 10:51 AM

Fri, Sep 14

calixte created D52090: [profile] Fix a test.
Fri, Sep 14, 5:55 AM
calixte created D52088: [GCOV] Don't add a useless block in the entry.
Fri, Sep 14, 5:54 AM

Thu, Sep 13

calixte updated the diff for D52033: [GCOV] Add options to filter files which must be instrumented..

Fix the nits

Thu, Sep 13, 1:42 PM
calixte added inline comments to D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov.
Thu, Sep 13, 1:38 PM
calixte added inline comments to D52033: [GCOV] Add options to filter files which must be instrumented..
Thu, Sep 13, 1:32 PM
calixte updated the summary of D52033: [GCOV] Add options to filter files which must be instrumented..
Thu, Sep 13, 7:19 AM
calixte created D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov.
Thu, Sep 13, 7:17 AM
calixte created D52033: [GCOV] Add options to filter files which must be instrumented..
Thu, Sep 13, 7:10 AM
calixte added a comment to D51974: [GCOV] Remove useless loop when emiting edge counters.

Thanks for the test case. The code for multiple CUs looks pretty buggy.
I'll have look on it to try to fix it.

Thu, Sep 13, 4:46 AM

Wed, Sep 12

calixte updated the summary of D51974: [GCOV] Remove useless loop when emiting edge counters.
Wed, Sep 12, 4:18 AM
calixte created D51974: [GCOV] Remove useless loop when emiting edge counters.
Wed, Sep 12, 4:15 AM

Tue, Sep 11

calixte added a comment to D51619: [gcov] Fix branch counters with switch statements.

@vsk I've no commit access, could you land this patch and this one https://reviews.llvm.org/D51620 please ?

Tue, Sep 11, 11:15 AM
calixte added a reviewer for D51620: [gcov] Fix the switch tests: vsk.
Tue, Sep 11, 11:11 AM
calixte created D51943: [GCOV] Remove function names from gcno when using option -coverage-no-function-names-in-data.
Tue, Sep 11, 10:51 AM
calixte updated the diff for D51619: [gcov] Fix branch counters with switch statements.
  • Fix nits
Tue, Sep 11, 10:18 AM
calixte added inline comments to D51619: [gcov] Fix branch counters with switch statements.
Tue, Sep 11, 10:12 AM
calixte updated the summary of D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
Tue, Sep 11, 6:45 AM
calixte updated the diff for D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
  • only put an ImplicitCode for EmitLandingPad
  • fix tests (were broken with clanf-format-diff)
Tue, Sep 11, 6:39 AM
calixte updated the diff for D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
  • Add some ImplicitCode when there is some stuff at the end of a function
  • Fix the tests
Tue, Sep 11, 5:17 AM
calixte updated the diff for D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
  • AsmWriter.cpp: print isImplicitCode only when it's true
  • Improve documentation for the new added flag
Tue, Sep 11, 2:47 AM · debug-info

Mon, Sep 10

calixte updated the diff for D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
  • Fix an error in MetadataLoader.cpp
  • Update tests to take into account the new added field
Mon, Sep 10, 2:06 AM · debug-info
calixte added a comment to D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.

ping ?

Mon, Sep 10, 12:38 AM · debug-info

Wed, Sep 5

calixte updated the diff for D49721: [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.org/D49659).

Fix switch test.

Wed, Sep 5, 2:30 AM
calixte updated the diff for D51619: [gcov] Fix branch counters with switch statements.

Remove useless function declaration

Wed, Sep 5, 2:18 AM

Tue, Sep 4

calixte created D51620: [gcov] Fix the switch tests.
Tue, Sep 4, 4:06 AM
calixte updated the summary of D51619: [gcov] Fix branch counters with switch statements.
Tue, Sep 4, 4:06 AM
calixte created D51619: [gcov] Fix branch counters with switch statements.
Tue, Sep 4, 4:02 AM

Wed, Aug 29

calixte updated the diff for D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
  • Use ImplicitCode instead of Covered
  • Set Artificial location as ImplicitCode to avoid coverage on landing pads
Wed, Aug 29, 5:54 AM
calixte updated the diff for D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
  • Use an available bit in Metadata to not increase the memory use
  • Update Writer/Reader for IR and Bitcode to take into account the new flag
Wed, Aug 29, 5:49 AM · debug-info

Aug 17 2018

calixte added inline comments to D49853: [gcov] Display the hit counter for the line of a function definition.
Aug 17 2018, 2:34 AM

Aug 14 2018

calixte added a comment to D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.

DILocation is a subclass of MDNode which is itself a subclass of Metadata. And in Metadata there is "unsigned char Storage" which uses only 2 bits so 6 bits are available here.
Maybe I could add "unsigned char ImplicitCode : 1" and "unsigned char Storage: 7" in class Metadata and so don't increase the DILocation size.
What do you think ?

Aug 14 2018, 4:42 AM · debug-info

Aug 13 2018

calixte added inline comments to D49853: [gcov] Display the hit counter for the line of a function definition.
Aug 13 2018, 4:55 AM
calixte updated the diff for D49853: [gcov] Display the hit counter for the line of a function definition.

Fix formatting.

Aug 13 2018, 4:51 AM
calixte updated the diff for D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.

Fix comments, function names and use llvm::find.

Aug 13 2018, 3:07 AM

Jul 27 2018

calixte updated the summary of D49917: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
Jul 27 2018, 7:26 AM
calixte created D49917: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
Jul 27 2018, 7:26 AM
calixte updated the summary of D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
Jul 27 2018, 7:24 AM · debug-info
calixte created D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required.
Jul 27 2018, 7:22 AM
calixte created D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not.
Jul 27 2018, 7:14 AM · debug-info

Jul 26 2018

calixte updated subscribers of D49854: [profile] Fix the gcov tests after the patch in D49853 landed..
Jul 26 2018, 7:15 AM
calixte removed a reviewer for D49853: [gcov] Display the hit counter for the line of a function definition: sylvestre.ledru.
Jul 26 2018, 7:14 AM
calixte updated the summary of D49853: [gcov] Display the hit counter for the line of a function definition.
Jul 26 2018, 7:14 AM
calixte created D49854: [profile] Fix the gcov tests after the patch in D49853 landed..
Jul 26 2018, 7:13 AM
calixte created D49853: [gcov] Display the hit counter for the line of a function definition.
Jul 26 2018, 7:09 AM

Jul 25 2018

calixte added a reviewer for D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line: davidxl.
Jul 25 2018, 8:19 AM
calixte updated subscribers of D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.
Jul 25 2018, 7:47 AM

Jul 24 2018

calixte retitled D49721: [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.org/D49659) from Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.org/D49659) to [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.org/D49659).
Jul 24 2018, 2:36 AM
calixte added a comment to D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.

This patch requires to accept https://reviews.llvm.org/D49721 too to fix tests in compiler-rt.

Jul 24 2018, 2:31 AM
calixte created D49721: [profile] Fix tests in compiler-rt for patch in gcov (https://reviews.llvm.org/D49659).
Jul 24 2018, 2:30 AM
calixte updated the diff for D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.

Fix a comment

Jul 24 2018, 2:27 AM
calixte updated the diff for D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.

Handle the case where a block has no predecessors and have a counter (such as entry blocks in functions).

Jul 24 2018, 2:25 AM

Jul 23 2018

calixte added a comment to D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.

Don't review for now: need to fix some things

Jul 23 2018, 7:53 AM
calixte updated the summary of D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.
Jul 23 2018, 4:29 AM
calixte created D49659: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.
Jul 23 2018, 2:18 AM