calixte (calixte)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2018, 8:06 AM (17 w, 5 d)

Recent Activity

Sat, Nov 17

calixte committed rL347144: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to….
[Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to…
Sat, Nov 17, 11:44 AM
calixte committed rC347144: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to….
[Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to…
Sat, Nov 17, 11:44 AM
calixte closed D54600: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659).
Sat, Nov 17, 11:44 AM
calixte updated the diff for D54599: [Profile] Avoid race condition when dumping GCDA files..
  • Update code to take into account what's wrong when fd==-1
  • Add a test for GCOV_PREFIX
Sat, Nov 17, 8:52 AM
calixte abandoned D54213: [Profile] Mark gcov-fork test as failinf for i386 target.
Sat, Nov 17, 3:52 AM

Thu, Nov 15

calixte updated the summary of D54599: [Profile] Avoid race condition when dumping GCDA files..
Thu, Nov 15, 2:35 PM
calixte added inline comments to D54599: [Profile] Avoid race condition when dumping GCDA files..
Thu, Nov 15, 2:26 PM
calixte updated the summary of D54599: [Profile] Avoid race condition when dumping GCDA files..
Thu, Nov 15, 2:25 PM
calixte created D54600: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659).
Thu, Nov 15, 2:03 PM
calixte created D54599: [Profile] Avoid race condition when dumping GCDA files..
Thu, Nov 15, 1:50 PM

Mon, Nov 12

calixte added a comment to rL346644: [GCOV] fix test after patch rL346642.

@RKSimon, thanks, I reverted.

Mon, Nov 12, 7:03 AM
calixte committed rL346659: Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c….
Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c…
Mon, Nov 12, 7:00 AM
calixte added a reverting commit for rL346642: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to…: rL346659: Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c….
Mon, Nov 12, 7:00 AM
calixte added a reverting commit for rL346644: [GCOV] fix test after patch rL346642: rL346659: Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c….
Mon, Nov 12, 7:00 AM
calixte committed rC346659: Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c….
Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c…
Mon, Nov 12, 6:59 AM
calixte added a comment to rL346644: [GCOV] fix test after patch rL346642.

@RKSimon, do you have an example fo failure, because I didn't get anything on mail nor on irc channel ?

Mon, Nov 12, 6:42 AM
calixte committed rC346644: [GCOV] fix test after patch rL346642.
[GCOV] fix test after patch rL346642
Mon, Nov 12, 1:55 AM
calixte committed rL346644: [GCOV] fix test after patch rL346642.
[GCOV] fix test after patch rL346642
Mon, Nov 12, 1:55 AM
calixte closed D54416: [GCOV] fix test after patch rL346642.
Mon, Nov 12, 1:55 AM
calixte updated the summary of D54416: [GCOV] fix test after patch rL346642.
Mon, Nov 12, 1:49 AM
calixte created D54416: [GCOV] fix test after patch rL346642.
Mon, Nov 12, 1:48 AM
calixte committed rL346642: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to….
[Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to…
Mon, Nov 12, 1:15 AM
calixte committed rC346642: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to….
[Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to…
Mon, Nov 12, 1:15 AM
calixte closed D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.
Mon, Nov 12, 1:15 AM
calixte committed rL346641: [GCOV] Add options to filter files which must be instrumented..
[GCOV] Add options to filter files which must be instrumented.
Mon, Nov 12, 1:04 AM
calixte closed D52033: [GCOV] Add options to filter files which must be instrumented..
Mon, Nov 12, 1:04 AM
calixte updated the diff for D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Forgot the ellipsis in the release notes.

Mon, Nov 12, 12:50 AM
calixte updated the diff for D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Update ReleaseNotes

Mon, Nov 12, 12:47 AM

Thu, Nov 8

calixte committed rL346409: [Profile] The test for gcov-fork seems to be ok on arm.
[Profile] The test for gcov-fork seems to be ok on arm
Thu, Nov 8, 8:18 AM
calixte committed rCRT346409: [Profile] The test for gcov-fork seems to be ok on arm.
[Profile] The test for gcov-fork seems to be ok on arm
Thu, Nov 8, 8:18 AM
calixte closed D54263: [Profile] The test for gcov-fork seems to be ok on arm.
Thu, Nov 8, 8:18 AM
calixte created D54263: [Profile] The test for gcov-fork seems to be ok on arm.
Thu, Nov 8, 7:19 AM

Wed, Nov 7

calixte created D54213: [Profile] Mark gcov-fork test as failinf for i386 target.
Wed, Nov 7, 9:09 AM
calixte committed rL346329: [Profile] Mark gcov-fork test as failing for arm.
[Profile] Mark gcov-fork test as failing for arm
Wed, Nov 7, 8:00 AM
calixte committed rCRT346329: [Profile] Mark gcov-fork test as failing for arm.
[Profile] Mark gcov-fork test as failing for arm
Wed, Nov 7, 8:00 AM
calixte closed D54209: [Profile] Mark gcov-fork test as failing for arm.
Wed, Nov 7, 8:00 AM
calixte created D54209: [Profile] Mark gcov-fork test as failing for arm.
Wed, Nov 7, 7:26 AM
calixte committed rL346318: Fix unit tests after patch https://reviews.llvm.org/rL346313.
Fix unit tests after patch https://reviews.llvm.org/rL346313
Wed, Nov 7, 6:49 AM
calixte closed D54208: Fix unit tests after patch https://reviews.llvm.org/rL346313.
Wed, Nov 7, 6:48 AM
calixte updated the diff for D54208: Fix unit tests after patch https://reviews.llvm.org/rL346313.

Fix nit.

Wed, Nov 7, 6:47 AM
calixte added inline comments to D54208: Fix unit tests after patch https://reviews.llvm.org/rL346313.
Wed, Nov 7, 6:47 AM
calixte created D54208: Fix unit tests after patch https://reviews.llvm.org/rL346313.
Wed, Nov 7, 6:42 AM
calixte committed rL346314: [Profile] Fix fork test and add tests for execlp and execvp after patch https….
[Profile] Fix fork test and add tests for execlp and execvp after patch https…
Wed, Nov 7, 5:53 AM
calixte committed rCRT346314: [Profile] Fix fork test and add tests for execlp and execvp after patch https….
[Profile] Fix fork test and add tests for execlp and execvp after patch https…
Wed, Nov 7, 5:53 AM
calixte closed D54167: [Profile] Fix fork test and add tests for execlp and execvp after patch https://reviews.llvm.org/D53593.
Wed, Nov 7, 5:53 AM
calixte committed rL346313: [GCOV] Flush counters before to avoid counting the execution before fork twice….
[GCOV] Flush counters before to avoid counting the execution before fork twice…
Wed, Nov 7, 5:53 AM
calixte closed D53593: [GCOV] Flush counters before to avoid counting the execution before fork twice and for exec** functions we must flush before the call.
Wed, Nov 7, 5:53 AM
calixte updated the diff for D54167: [Profile] Fix fork test and add tests for execlp and execvp after patch https://reviews.llvm.org/D53593.

Fix execvp test.

Wed, Nov 7, 5:29 AM
calixte updated the diff for D53593: [GCOV] Flush counters before to avoid counting the execution before fork twice and for exec** functions we must flush before the call.

Handle execve, fix issues with execvp and remove _WIN32.

Wed, Nov 7, 5:29 AM
calixte accepted D53988: Close file mapping handle on Windows, so flushed gcda files can be removed while the process is in execution.

Looks good to me.

Wed, Nov 7, 1:30 AM
calixte added a reviewer for D51974: [GCOV] Handle correctly multiple CUs when profiling: marco-c.
Wed, Nov 7, 1:07 AM
calixte updated the diff for D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Update doc.

Wed, Nov 7, 12:52 AM

Tue, Nov 6

calixte created D54167: [Profile] Fix fork test and add tests for execlp and execvp after patch https://reviews.llvm.org/D53593.
Tue, Nov 6, 11:22 AM
calixte retitled D53593: [GCOV] Flush counters before to avoid counting the execution before fork twice and for exec** functions we must flush before the call from [GCOV] Flush counters before forking to avoid counting the execution before fork twice to [GCOV] Flush counters before to avoid counting the execution before fork twice and for exec** functions we must flush before the call.
Tue, Nov 6, 11:18 AM
calixte updated the diff for D53593: [GCOV] Flush counters before to avoid counting the execution before fork twice and for exec** functions we must flush before the call.

Fix comments from vsk and handle exec** functions too.

Tue, Nov 6, 11:16 AM
calixte updated the diff for D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Fix plural form of regex and just use ';' as separator.

Tue, Nov 6, 6:49 AM
calixte updated the diff for D52033: [GCOV] Add options to filter files which must be instrumented..

Fix plural form of regex and just use ';' as separator.

Tue, Nov 6, 6:49 AM
calixte retitled D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov from [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov to [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.
Tue, Nov 6, 6:19 AM
calixte updated the diff for D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Change options names to -fprofile-exclude-files & -fprofile-filter-files and add some doc in UserManual.

Tue, Nov 6, 6:18 AM
calixte updated the diff for D52033: [GCOV] Add options to filter files which must be instrumented..

Regexs separator is ':' for Unix and ';' for Windows

Tue, Nov 6, 6:14 AM
calixte added inline comments to D53988: Close file mapping handle on Windows, so flushed gcda files can be removed while the process is in execution.
Tue, Nov 6, 2:35 AM

Tue, Oct 30

calixte committed rCRT345625: [GCOV] Add a test for function defined on one line (follow-up of https….
[GCOV] Add a test for function defined on one line (follow-up of https…
Tue, Oct 30, 11:44 AM
calixte committed rL345625: [GCOV] Add a test for function defined on one line (follow-up of https….
[GCOV] Add a test for function defined on one line (follow-up of https…
Tue, Oct 30, 11:44 AM
calixte closed D53601: [GCOV] Add a test for function defined on one line (follow-up of https://reviews.llvm.org/D53600).
Tue, Oct 30, 11:43 AM
calixte committed rL345624: [GCOV] Function counters are wrong when on one line.
[GCOV] Function counters are wrong when on one line
Tue, Oct 30, 11:43 AM
calixte closed D53600: [GCOV] Function counters are wrong when on one line.
Tue, Oct 30, 11:43 AM
calixte added inline comments to D53593: [GCOV] Flush counters before to avoid counting the execution before fork twice and for exec** functions we must flush before the call.
Tue, Oct 30, 10:16 AM

Tue, Oct 23

calixte updated the summary of D53600: [GCOV] Function counters are wrong when on one line.
Tue, Oct 23, 12:10 PM
calixte created D53601: [GCOV] Add a test for function defined on one line (follow-up of https://reviews.llvm.org/D53600).
Tue, Oct 23, 12:10 PM
calixte created D53600: [GCOV] Function counters are wrong when on one line.
Tue, Oct 23, 12:06 PM
calixte created D53593: [GCOV] Flush counters before to avoid counting the execution before fork twice and for exec** functions we must flush before the call.
Tue, Oct 23, 11:20 AM
calixte created D53578: [CodeGen] Fix clang test for gcov profiling (follow-up of D51974).
Tue, Oct 23, 8:23 AM
calixte retitled D51974: [GCOV] Handle correctly multiple CUs when profiling from [GCOV] Remove useless loop when emiting edge counters to [GCOV] Handle correctly multiple CUs when profiling.
Tue, Oct 23, 8:16 AM
calixte updated the diff for D51974: [GCOV] Handle correctly multiple CUs when profiling.

Fix multiple CUs stuff and add a test (thanks to vsk).

Tue, Oct 23, 8:13 AM

Oct 18 2018

calixte added a comment to D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

@vsk, gcc guys are ok for -fprofile-filter-files and -fprofile-exclude-files, are you ok with that ?
Should these options prefixed by -Xclang or not ?

Oct 18 2018, 4:42 AM

Oct 11 2018

calixte committed rL344229: [profile] Fix the gcov tests after the patch in D49853 landed..
[profile] Fix the gcov tests after the patch in D49853 landed.
Oct 11 2018, 1:55 AM
calixte committed rCRT344229: [profile] Fix the gcov tests after the patch in D49853 landed..
[profile] Fix the gcov tests after the patch in D49853 landed.
Oct 11 2018, 1:55 AM
calixte closed D49854: [profile] Fix the gcov tests after the patch in D49853 landed..
Oct 11 2018, 1:55 AM
calixte committed rL344228: [gcov] Display the hit counter for the line of a function definition.
[gcov] Display the hit counter for the line of a function definition
Oct 11 2018, 1:55 AM
calixte closed D49853: [gcov] Display the hit counter for the line of a function definition.
Oct 11 2018, 1:55 AM
calixte updated the diff for D49853: [gcov] Display the hit counter for the line of a function definition.

Don't get EntryBlock again

Oct 11 2018, 1:46 AM

Oct 10 2018

calixte updated the diff for D49854: [profile] Fix the gcov tests after the patch in D49853 landed..

Fix profile tests

Oct 10 2018, 10:25 AM

Sep 26 2018

calixte added a comment to D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

I reported a bug for gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87442
@vsk I'd like to add documentation in Docs/UsersManual.rst, but I've no idea on what's a good place for this (I look for option -coverage-no-function-names-in-data, but I didn't get anything). So could you give a me a clue please ?

Sep 26 2018, 4:23 AM
calixte updated the diff for D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov.

Fix tests

Sep 26 2018, 4:17 AM
calixte updated the diff for D52033: [GCOV] Add options to filter files which must be instrumented..

Fix nits

Sep 26 2018, 4:16 AM
calixte added inline comments to D52033: [GCOV] Add options to filter files which must be instrumented..
Sep 26 2018, 12:00 AM

Sep 25 2018

calixte added inline comments to D52033: [GCOV] Add options to filter files which must be instrumented..
Sep 25 2018, 9:31 AM
calixte committed rL342963: [Profile] Fix gcov tests.
[Profile] Fix gcov tests
Sep 25 2018, 4:16 AM
calixte committed rCRT342963: [Profile] Fix gcov tests.
[Profile] Fix gcov tests
Sep 25 2018, 4:16 AM
calixte closed D52456: [Profile] Fix gcov tests.
Sep 25 2018, 4:16 AM
calixte added a reviewer for D52456: [Profile] Fix gcov tests: eugenis.
Sep 25 2018, 4:03 AM
calixte created D52456: [Profile] Fix gcov tests.
Sep 25 2018, 3:58 AM

Sep 24 2018

calixte committed rCRT342913: [profile] Revert commit https://reviews.llvm.org/rL342718.
[profile] Revert commit https://reviews.llvm.org/rL342718
Sep 24 2018, 11:29 AM
calixte committed rL342913: [profile] Revert commit https://reviews.llvm.org/rL342718.
[profile] Revert commit https://reviews.llvm.org/rL342718
Sep 24 2018, 11:29 AM
calixte committed rC342912: [CodeGen] Revert commit https://reviews.llvm.org/rL342717.
[CodeGen] Revert commit https://reviews.llvm.org/rL342717
Sep 24 2018, 11:29 AM
calixte committed rL342912: [CodeGen] Revert commit https://reviews.llvm.org/rL342717.
[CodeGen] Revert commit https://reviews.llvm.org/rL342717
Sep 24 2018, 11:29 AM
calixte updated the diff for D49854: [profile] Fix the gcov tests after the patch in D49853 landed..

Update the tests

Sep 24 2018, 10:31 AM
calixte added a comment to rL342657: [gcov] Fix wrong line hit counts when multiple blocks are on the same line.

According to the logs, there is an issue in the # of Runs for each file which should be fixed in clearing directory build/projects/compiler-rt/test/profile/Profile-x86_64/Output/ on build machines.
@lei how can I do that ?

Sep 24 2018, 7:31 AM

Sep 21 2018

calixte committed rCRT342718: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
[profile] Fix the tests for patch in https://reviews.llvm.org/D49916.
Sep 21 2018, 2:19 AM
calixte committed rL342718: [profile] Fix the tests for patch in https://reviews.llvm.org/D49916..
[profile] Fix the tests for patch in https://reviews.llvm.org/D49916.
Sep 21 2018, 2:19 AM