This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean expressions in AArch64 target
ClosedPublic

Authored by LegalizeAdulthood on Mar 22 2015, 1:01 PM.

Diff Detail

Event Timeline

LegalizeAdulthood retitled this revision from to Refacotr; Simplify boolean expressions in AArch64 target.
LegalizeAdulthood updated this object.
LegalizeAdulthood edited the test plan for this revision. (Show Details)
LegalizeAdulthood added a subscriber: Unknown Object (MLST).

On all three instances, please, keep the parenthesis, to avoid future problems with order of operators.

alexfh edited edge metadata.Mar 22 2015, 3:20 PM

On all three instances, please, keep the parenthesis, to avoid future problems with order of operators.

Do you find the order of operations unclear as it is now or do you expect confusion later if the code is changed?

I personally find return a < b; nicer and more consistent with existing code than return (a < b);.

rengolin accepted this revision.Mar 23 2015, 8:56 AM
rengolin added a reviewer: rengolin.

I guess you're right. Let it be for whomever change this to make sure operator precedence is followed. LGTM, Thanks!

This revision is now accepted and ready to land.Mar 23 2015, 8:56 AM
LegalizeAdulthood retitled this revision from Refacotr; Simplify boolean expressions in AArch64 target to Refactor: Simplify boolean expressions in AArch64 target.Mar 23 2015, 9:40 AM
LegalizeAdulthood edited edge metadata.

Can someone commit this for me, please? I don't have commit access.

Patch by Richard Thomson

Can someone commit this for me, please? I don't have commit access.

Patch by Richard Thomson

This revision was automatically updated to reflect the committed changes.

Committed in r233089