Page MenuHomePhabricator
Differential D85215

[HotColdSplit] Remove target triples from architecture-agnostic testcases
AbandonedPublic
Actions

Authored by hiraditya on Aug 4 2020, 8:53 AM.

Details

Reviewers
rcorcs
vsk
tejohnson
CarolineConcatto
JamesNagurne
rjf
Summary

This fixes the build errors on ARM machines ; see relevant discussions in D85148
and D69384.

Diff Detail

Unit TestsFailed
View All

TimeTest
270 mslinux > LLVM.Transforms/HotColdSplit::coldentrycount.ll
Script: -- : 'RUN: at line 4'; /mnt/disks/ssd0/agent/llvm-project/build/bin/opt -hotcoldsplit -hotcoldsplit-threshold=0 -codegenprepare -S < /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/HotColdSplit/coldentrycount.ll | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/Transforms/HotColdSplit/coldentrycount.ll
130 mswindows > LLVM.Transforms/HotColdSplit::coldentrycount.ll
Script: -- : 'RUN: at line 4'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\opt.exe -hotcoldsplit -hotcoldsplit-threshold=0 -codegenprepare -S < C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\Transforms\HotColdSplit\coldentrycount.ll | c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\Transforms\HotColdSplit\coldentrycount.ll

Event Timeline

rjf created this revision.Aug 4 2020, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2020, 8:53 AM
Herald added subscribers: llvm-commits, kristof.beyls. · View Herald Transcript
rjf requested review of this revision.Aug 4 2020, 8:53 AM
hiraditya accepted this revision.Aug 4 2020, 8:54 AM

Thanks for fixing it quickly @rjf

This revision is now accepted and ready to land.Aug 4 2020, 8:54 AM
hiraditya mentioned this in D69384: [HotColdSplit] Add unlikely attribute to outlined function.Aug 4 2020, 8:54 AM
hiraditya added reviewers: vsk, tejohnson.
JamesNagurne mentioned this in D85148: Fix ARM build bots failures due to disabled x86_64-apple target.Aug 4 2020, 8:57 AM
rjf mentioned this in D69257: Outline non returning functions unless a longjmp.Aug 4 2020, 9:00 AM
rjf added reviewers: CarolineConcatto, JamesNagurne.
rjf added a comment.Aug 4 2020, 9:38 AM

Looks like coldentrycount.ll is still causing a problem @hiraditya .

Harbormaster completed remote builds in B66947: Diff 282937.Aug 4 2020, 9:52 AM
RKSimon added a subscriber: RKSimon.Aug 4 2020, 10:43 AM
In D85215#2193705, @rjf wrote:

Looks like coldentrycount.ll is still causing a problem @hiraditya .

If this is not going to work anytime soon - it would be better to revert the original patch for now.

hiraditya added a comment.Aug 4 2020, 10:50 AM

Should I land D85148 then? I'd like to keep the test case if possible.

hiraditya commandeered this revision.Aug 4 2020, 10:53 AM
hiraditya edited reviewers, added: rjf; removed: hiraditya.
This revision now requires review to proceed.Aug 4 2020, 10:53 AM
hiraditya abandoned this revision.Aug 4 2020, 10:53 AM

will revert the old patch.

hiraditya added a comment.Aug 4 2020, 11:18 AM

reverted : D85229

hiraditya added a comment.Aug 4 2020, 1:52 PM

Fixed in: D85232

Revision Contents
Changeset List

PathSize
llvm/
test/
Transforms/
HotColdSplit/
3 lines
2 lines
3 lines
2 lines
2 lines

Diff 282937

View Options

llvm/test/Transforms/HotColdSplit/coldentrycount.ll

Loading...
View Options

llvm/test/Transforms/HotColdSplit/longjmp-nosplit.ll

Loading...
View Options

llvm/test/Transforms/HotColdSplit/longjmp-split.ll

Loading...
View Options

llvm/test/Transforms/HotColdSplit/sjlj-nosplit.ll

Loading...
View Options

llvm/test/Transforms/HotColdSplit/sjlj-split.ll

Loading...