This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Implement fewerElementsVector for G_CONCAT_VECTORS sources
ClosedPublic

Authored by arsenm on Aug 4 2020, 5:30 AM.

Details

Summary

This fixes <6 x s16> = G_CONCAT_VECTORS from <3 x s16> handling.

Diff Detail

Event Timeline

arsenm created this revision.Aug 4 2020, 5:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2020, 5:30 AM
arsenm requested review of this revision.Aug 4 2020, 5:30 AM
paquette added inline comments.Aug 6 2020, 1:13 PM
llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
204

Doxygen comment for this variant?

arsenm updated this revision to Diff 283721.Aug 6 2020, 1:32 PM

Try to make comments better

aemerson added inline comments.Aug 17 2020, 10:49 AM
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
253

Why these changes to this function? The new behavior doesn't match the comment for it.

arsenm added inline comments.Aug 17 2020, 10:53 AM
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
253

Before it would clear the original vector, so you couldn't repeatedly call this and accumulate in Regs without a temporary vector. This switches it to append

arsenm updated this revision to Diff 286086.Aug 17 2020, 10:54 AM

Update comment

aemerson accepted this revision.Aug 19 2020, 2:31 PM
This revision is now accepted and ready to land.Aug 19 2020, 2:31 PM