Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Conversion/GPUCommon/ConvertLaunchFuncToRuntimeCalls.cpp | ||
---|---|---|
298–299 | Would it make sense to make this a member function of gpu::LaunchFuncOp if this lookup is done in multiple places? |
mlir/lib/Conversion/GPUCommon/ConvertLaunchFuncToRuntimeCalls.cpp | ||
---|---|---|
298–299 | As far as I can tell, this is only used here. |
mlir/lib/Conversion/GPUCommon/ConvertLaunchFuncToRuntimeCalls.cpp | ||
---|---|---|
287–292 | Maybe put this lambda in a local and give it a name? |
nit: formatting