Page MenuHomePhabricator

[NewPM][LoopVersioning] Port LoopVersioning to NPM
ClosedPublic

Authored by aeubanks on Jul 31 2020, 5:34 PM.

Diff Detail

Event Timeline

aeubanks created this revision.Jul 31 2020, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2020, 5:34 PM
aeubanks requested review of this revision.Jul 31 2020, 5:34 PM
ychen added a comment.Jul 31 2020, 6:54 PM

Add a test case in llvm/test/Transforms/LoopVersioning/basic.ll? Where is the unit test for this (if there is any)?

llvm/lib/Transforms/Utils/LoopVersioning.cpp
259

use function_ref since it is a one-time use/ref of a callable.

275

delete

363

extra brace

aeubanks updated this revision to Diff 282365.Jul 31 2020, 8:17 PM

Address review comments

ychen accepted this revision.Jul 31 2020, 9:47 PM

LGTM

llvm/lib/Transforms/Utils/LoopVersioning.cpp
300–303

format?

This revision is now accepted and ready to land.Jul 31 2020, 9:47 PM
aeubanks updated this revision to Diff 282672.Aug 3 2020, 10:18 AM

clang-format

fhahn accepted this revision.Aug 3 2020, 10:20 AM

Thanks for porting this! LGTM

This revision was landed with ongoing or failed builds.Aug 3 2020, 10:32 AM
This revision was automatically updated to reflect the committed changes.