I fixed an assert caused by passing an empty array as the source= argument to
RESHAPE(). In the process, I noticed that there were no tests for RESHAPE(),
so I wrote a test that covers all the description in 16.9.163. In the process,
I made the error messages more consistent and descriptive. I also changed the
test to see if a reference to an intrinsic function was a constant to say that
it is a constant if it's a refererence to an invalid intrinsic. This avoids
emitting multiple messages for the same erroneous source.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
flang/lib/Evaluate/check-expression.cpp | ||
---|---|---|
49 | This string should be a named constant, maybe in fold-implementation.h. |
Comment Actions
I fixed the error messages to put quotes around the names of arguments.
I also created a constant for the name of the invalid intrinsic created when
constant folding runs into errors.
This string should be a named constant, maybe in fold-implementation.h.