This is an archive of the discontinued LLVM Phabricator instance.

Differential D84840

[mlir][Linalg] Conv ops lowering to std calls added.
ClosedPublic

Authored by limo1996 on Jul 29 2020, 5:50 AM.

Details

Reviewers
ftynse
nicolasvasilache
Commits
rG689096965d9a: [mlir][Linalg] Conv ops lowering to std calls added.
Summary

Lowering of newly defined Conv ops in TC syntax to standard
dialect is not supported and therefore this commit adds support
for it.

Diff Detail

Event Timeline

limo1996 created this revision.Jul 29 2020, 5:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2020, 5:50 AM
Herald added subscribers: msifontes, jurahul, Kayjukh and 12 others. · View Herald Transcript
limo1996 requested review of this revision.Jul 29 2020, 5:50 AM
Herald added a subscriber: stephenneuendorffer. · View Herald TranscriptJul 29 2020, 5:50 AM
Harbormaster completed remote builds in B66187: Diff 281541.Jul 29 2020, 5:50 AM
ftynse accepted this revision.Jul 31 2020, 4:48 AM
This revision is now accepted and ready to land.Jul 31 2020, 4:48 AM
limo1996 edited the summary of this revision. (Show Details)Aug 3 2020, 12:57 AM
limo1996 updated this revision to Diff 282624.Aug 3 2020, 7:47 AM
limo1996 edited the summary of this revision. (Show Details)

rebased

Harbormaster completed remote builds in B66773: Diff 282624.Aug 3 2020, 8:34 AM
limo1996 updated this revision to Diff 282809.Aug 4 2020, 12:13 AM

rebased

This revision was landed with ongoing or failed builds.Aug 4 2020, 12:15 AM
Closed by commit rG689096965d9a: [mlir][Linalg] Conv ops lowering to std calls added. (authored by limo1996). · Explain Why
This revision was automatically updated to reflect the committed changes.
limo1996 added a commit: rG689096965d9a: [mlir][Linalg] Conv ops lowering to std calls added..
Harbormaster completed remote builds in B66880: Diff 282809.Aug 4 2020, 12:30 AM

Revision Contents

PathSize
mlir/
lib/
Conversion/
LinalgToStandard/
11 lines

Diff 282810

mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp

Show First 20 Lines • Show All 238 Lines • ▼ Show 20 Lines patterns.insert<
LinalgOpConversion<FillOp>, LinalgOpConversion<FillOp>,
LinalgOpConversion<GenericOp>, LinalgOpConversion<GenericOp>,
LinalgOpConversion<IndexedGenericOp>>(ctx); LinalgOpConversion<IndexedGenericOp>>(ctx);
// TODO: collect all auto-generated named ops with a tblgen directive. // TODO: collect all auto-generated named ops with a tblgen directive.
patterns.insert< patterns.insert<
LinalgOpConversion<DotOp>, LinalgOpConversion<DotOp>,
LinalgOpConversion<BatchMatmulOp>, LinalgOpConversion<BatchMatmulOp>,
LinalgOpConversion<MatvecOp>, LinalgOpConversion<MatvecOp>,
LinalgOpConversion<MatmulOp>>(ctx); LinalgOpConversion<MatmulOp>,
LinalgOpConversion<ConvWOp>,
LinalgOpConversion<ConvNWCOp>,
LinalgOpConversion<ConvNCWOp>,
LinalgOpConversion<ConvHWOp>,
LinalgOpConversion<ConvNHWCOp>,
LinalgOpConversion<ConvNCHWOp>,
LinalgOpConversion<ConvDHWOp>,
LinalgOpConversion<ConvNDHWCOp>,
LinalgOpConversion<ConvNCDHWOp>>(ctx);
// clang-format on // clang-format on
} }
namespace { namespace {
struct ConvertLinalgToStandardPass struct ConvertLinalgToStandardPass
: public ConvertLinalgToStandardBase<ConvertLinalgToStandardPass> { : public ConvertLinalgToStandardBase<ConvertLinalgToStandardPass> {
void runOnOperation() override; void runOnOperation() override;
}; };
Show All 18 Lines