This is an archive of the discontinued LLVM Phabricator instance.

[SROA][Mem2Reg] Use efficient droppable use API (after D83976)
ClosedPublic

Authored by jdoerfert on Jul 28 2020, 2:56 PM.

Diff Detail

Unit TestsFailed

Event Timeline

jdoerfert created this revision.Jul 28 2020, 2:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 2:56 PM
jdoerfert requested review of this revision.Jul 28 2020, 2:56 PM
efriedma accepted this revision.Jul 28 2020, 3:21 PM

The new removeIntrinsicUsers is much nicer; LGTM

llvm/lib/Transforms/Scalar/SROA.cpp
3090

We could pass down the Use here, if we cared; the caller computes it. But this is okay for now.

This revision is now accepted and ready to land.Jul 28 2020, 3:21 PM
jdoerfert added inline comments.Jul 28 2020, 3:23 PM
llvm/lib/Transforms/Scalar/SROA.cpp
3090

Yeah, that would have been a bit more intrusive (on first glance).

llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
325

FWIW, this was actually broken anyway...

Tyker added inline comments.Jul 28 2020, 3:25 PM
llvm/lib/IR/Value.cpp
183

we could add an
assert(Usr->isDroppable());

This revision was landed with ongoing or failed builds.Jul 28 2020, 3:42 PM
This revision was automatically updated to reflect the committed changes.
jdoerfert marked an inline comment as done.