Page MenuHomePhabricator

[NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard
ClosedPublic

Authored by tianshilei1992 on Jul 28 2020, 1:39 PM.

Details

Summary

This patch only touched variables and functions in target.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jul 28 2020, 1:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 1:39 PM
tianshilei1992 requested review of this revision.Jul 28 2020, 1:39 PM
tianshilei1992 retitled this revision from [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard to [NFC][OpenMP] Renamed all variable and function names in `target` to conformwith LLVM code standard.Jul 28 2020, 1:40 PM
tianshilei1992 edited the summary of this revision. (Show Details)
tianshilei1992 added a reviewer: ye-luo.

Should be easy to address my comments and let us get this merged ASAP.

openmp/libomptarget/src/device.h
202

"Function names should be verb phrases (as they represent actions), and command-like function should be imperative. The name should be camel case, and start with a lower case letter (e.g. openFile() or isFoo())."

Since we are anyway changing the names. Let us fix them fully.
allocData
deleteData
Please also take this chance to rename
data_retrieve
data_exchange
as well. No good reason to leave these pains.

openmp/libomptarget/src/omptarget.cpp
213

isMemberOf?

openmp/libomptarget/src/private.h
29

Let us kill the pain in one shot. It is just a few more sed.

Renamed some function names

tianshilei1992 marked 3 inline comments as done.Jul 28 2020, 2:10 PM
tianshilei1992 added inline comments.
openmp/libomptarget/src/device.h
202

I would like to just focus on the functions related to target just as the title said. I'll do it in the future if they're still there and I'm gonna touch them.

openmp/libomptarget/src/private.h
29

As replied above.

tianshilei1992 marked 2 inline comments as done.Jul 28 2020, 2:10 PM
ye-luo accepted this revision.Jul 28 2020, 2:15 PM

OK. Leave the unrelated renaming to the future.

This revision is now accepted and ready to land.Jul 28 2020, 2:15 PM
tianshilei1992 retitled this revision from [NFC][OpenMP] Renamed all variable and function names in `target` to conformwith LLVM code standard to [NFC][OpenMP] Renamed all variable and function names in `target` to conform with LLVM code standard.Jul 28 2020, 2:32 PM
This revision was landed with ongoing or failed builds.Jul 28 2020, 5:11 PM
This revision was automatically updated to reflect the committed changes.