Page MenuHomePhabricator

[OpenMP] Replaced mutex lock/unlock in `target` with `std::lock_guard`
ClosedPublic

Authored by tianshilei1992 on Jul 28 2020, 1:52 PM.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jul 28 2020, 1:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 1:52 PM
tianshilei1992 requested review of this revision.Jul 28 2020, 1:52 PM

Only one minor issue. Your initial sophisticated patch made my thought you replaced all the lock/unlock. After splitting, the change becomes very clean.

openmp/libomptarget/src/omptarget.cpp
766–772

Pull nullptr initial value.

Initialize TargetTable`

ye-luo accepted this revision.Jul 28 2020, 2:16 PM

LGTM

This revision is now accepted and ready to land.Jul 28 2020, 2:16 PM