[clang-tidy][NFC] Replace comment by private method

[hanneskaeufler]

Summary

The comment is better served with a small private
method, helping scannability of the code and
hiding irrelevant details about the private members.

[hanneskaeufler]

Fix syntax error (add return type)

[aaron.ballman]

LGTM!

[hanneskaeufler]

In D84591#2174437, @aaron.ballman wrote:

LGTM!

Awesome, thanks!

[aaron.ballman]

In D84591#2174442, @hanneskaeufler wrote:

In D84591#2174437, @aaron.ballman wrote:

LGTM!

Awesome, thanks!

Do you need someone to commit on your behalf? If so, can you give me the name and email address you'd like me to attribute the commit to (I've got Hannes Käufler <[e-mail]>)?

[hanneskaeufler]

In D84591#2174447, @aaron.ballman wrote:

In D84591#2174442, @hanneskaeufler wrote:

In D84591#2174437, @aaron.ballman wrote:

LGTM!

Awesome, thanks!

Do you need someone to commit on your behalf? If so, can you give me the name and email address you'd like me to attribute the commit to (I've got Hannes Käufler <[e-mail]>)?

Uh, yeah, I don't suppose I have commit rights. First time contributor here :) Name and E-Mail is correct!

[aaron.ballman]

In D84591#2174473, @hanneskaeufler wrote:

In D84591#2174447, @aaron.ballman wrote:

In D84591#2174442, @hanneskaeufler wrote:

In D84591#2174437, @aaron.ballman wrote:

LGTM!

Awesome, thanks!

Do you need someone to commit on your behalf? If so, can you give me the name and email address you'd like me to attribute the commit to (I've got Hannes Käufler <[e-mail]>)?

Uh, yeah, I don't suppose I have commit rights. First time contributor here :) Name and E-Mail is correct!

Thank you for the patch! I've committed on your behalf in 3bbf3e026d3c692966583075ae6d12c4575e9d72.

clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp

for (const auto &MacroEntry : Macros) {
                              "guard macro in a comment")
               << FixIts;
         }
       }
     }
 
     // Emit warnings for headers that are missing guards.
     checkGuardlessHeaders();
-
-    // Clear all state.
-    Macros.clear();
-    Files.clear();
-    Ifndefs.clear();
-    EndIfs.clear();
+    clearAllState();
   }
 
   bool wouldFixEndifComment(StringRef FileName, SourceLocation EndIf,
                             StringRef HeaderGuard,
                             size_t *EndIfLenPtr = nullptr) {
     if (!EndIf.isValid())
       return false;
     const char *EndIfData = PP->getSourceManager().getCharacterData(EndIf);
for (const auto &FE : Files) {
                  SM.getLocForEndOfFile(FID),
                  Check->shouldSuggestEndifComment(FileName)
                      ? "\n#" + Check->formatEndIf(CPPVar) + "\n"
                      : "\n#endif\n");
     }
   }
 
 private:
+  void clearAllState() {
+    Macros.clear();
+    Files.clear();
+    Ifndefs.clear();
+    EndIfs.clear();
+  }
+
   std::vector<std::pair<Token, const MacroInfo *>> Macros;
   llvm::StringMap<const FileEntry *> Files;
   std::map<const IdentifierInfo *, std::pair<SourceLocation, SourceLocation>>
       Ifndefs;
   std::map<SourceLocation, SourceLocation> EndIfs;
 
   Preprocessor *PP;
   HeaderGuardCheck *Check;