This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] ubsan/asan illumos linkage fix
AbandonedPublic

Authored by devnexen on Jul 24 2020, 2:43 PM.

Details

Reviewers
ro
Summary
  • No support for --version-script flag thus making it conditional

Diff Detail

Event Timeline

devnexen created this revision.Jul 24 2020, 2:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2020, 2:43 PM
Herald added subscribers: Restricted Project, fedor.sergeev, mgorny, dberris. · View Herald Transcript
ro added a comment.Jul 24 2020, 3:01 PM

This is wrong: LLVM_LINKER_IS_SOLARISLD is YES on Solaris 11.4 (supports both --version-script and -z gnu-version-script-compat),
Solaris 11.3 and Illumos (support neither), so this disables --version-script on Solaris 11.4.

I've just submitted D84559 which handles all cases correctly.

devnexen abandoned this revision.Jul 24 2020, 3:24 PM