This is an archive of the discontinued LLVM Phabricator instance.

Differential D84266

[flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC
ClosedPublic

Authored by AlexisPerry on Jul 21 2020, 1:16 PM.

Details

Reviewers
jdoerfert
DavidTruby
naromero77
sscalpone
richard.barton.arm
Commits
rG4a4cafabc906: [flang] Temp Driver - pass the flag to change the default integer kind through…
Summary

fixes BUG 46307

Diff Detail

Event Timeline

AlexisPerry created this revision.Jul 21 2020, 1:16 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJul 21 2020, 1:16 PM
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
AlexisPerry added reviewers: naromero77, sscalpone, richard.barton.arm.Jul 21 2020, 1:24 PM
AlexisPerry added a subscriber: flang-commits.
Harbormaster completed remote builds in B65137: Diff 279621.Jul 21 2020, 1:44 PM
naromero77 added a comment.Jul 21 2020, 2:09 PM

Thanks Alexis, give me a day or two to get back to you.

sscalpone accepted this revision.Jul 21 2020, 2:39 PM

Look good. Thanks. P.S. Is someone going to ask about -r8 soon?

This revision is now accepted and ready to land.Jul 21 2020, 2:39 PM
naromero77 accepted this revision.Jul 21 2020, 6:03 PM

Tested with Gfortran and PGI. Looks good

@sscalpone I have not run into -r8 so far with the DOE SC codes that I have been compiling. If I run into it, I can make the Differential in Phabricator to add it.

AlexisPerry added a comment.Jul 27 2020, 7:56 AM

I don't know what changed between my last patch and now, but I am unable to land this patch myself. I keep getting the following error:
EXCEPTION: (ConduitClientException) ERR-CONDUIT-CALL: Conduit API method "harbormaster.buildable.search" does not exist. at [<arcanist>/src/conduit/ConduitFuture.php:65]

Do any of you know how to fix this error so I can land the patch? If this isn't fixable, would one of you be willing to land the patch on my behalf? Thanks!

tskeith added a subscriber: tskeith.Jul 27 2020, 9:55 AM
In D84266#2175971, @AlexisPerry wrote:

I don't know what changed between my last patch and now, but I am unable to land this patch myself. I keep getting the following error:
EXCEPTION: (ConduitClientException) ERR-CONDUIT-CALL: Conduit API method "harbormaster.buildable.search" does not exist. at [<arcanist>/src/conduit/ConduitFuture.php:65]

Do any of you know how to fix this error so I can land the patch? If this isn't fixable, would one of you be willing to land the patch on my behalf? Thanks!

I can't explain the problem but arcanist is working for me so I can land it for you.

Closed by commit rG4a4cafabc906: [flang] Temp Driver - pass the flag to change the default integer kind through… (authored by AlexisPerry, committed by tskeith). · Explain WhyJul 27 2020, 9:58 AM
This revision was automatically updated to reflect the committed changes.
lsqtongxin added a subscriber: lsqtongxin.Dec 2 2020, 11:48 PM
In D84266#2175971, @AlexisPerry wrote:

I don't know what changed between my last patch and now, but I am unable to land this patch myself. I keep getting the following error:
EXCEPTION: (ConduitClientException) ERR-CONDUIT-CALL: Conduit API method "harbormaster.buildable.search" does not exist. at [<arcanist>/src/conduit/ConduitFuture.php:65]

Do any of you know how to fix this error so I can land the patch? If this isn't fixable, would one of you be willing to land the patch on my behalf? Thanks!

how to resolve the problem ? I have the same error when I land my code,but I have no idea.
EXCEPTION: (ConduitClientException) ERR-CONDUIT-CALL: Conduit API method "harbormaster.buildable.search" does not exist. at [<arcanist>/src/conduit/ConduitFuture.php:70]

Revision Contents

PathSize
flang/
tools/
f18/
5 lines

Diff 279621

flang/tools/f18/f18.cpp

Show First 20 Lines • Show All 538 Lines • ▼ Show 20 Lines while (!args.empty()) {
} else if (arg == "-fdefault-double-8") { } else if (arg == "-fdefault-double-8") {
defaultKinds.set_defaultRealKind(4); defaultKinds.set_defaultRealKind(4);
} else if (arg == "-r8" || arg == "-fdefault-real-8") { } else if (arg == "-r8" || arg == "-fdefault-real-8") {
defaultKinds.set_defaultRealKind(8); defaultKinds.set_defaultRealKind(8);
} else if (arg == "-i8" || arg == "-fdefault-integer-8") { } else if (arg == "-i8" || arg == "-fdefault-integer-8") {
defaultKinds.set_defaultIntegerKind(8); defaultKinds.set_defaultIntegerKind(8);
defaultKinds.set_subscriptIntegerKind(8); defaultKinds.set_subscriptIntegerKind(8);
defaultKinds.set_sizeIntegerKind(8); defaultKinds.set_sizeIntegerKind(8);
if (isPGF90) {
driver.F18_FCArgs.push_back("-i8");
} else {
driver.F18_FCArgs.push_back("-fdefault-integer-8");
}
} else if (arg == "-Mlargearray") { } else if (arg == "-Mlargearray") {
} else if (arg == "-Mnolargearray") { } else if (arg == "-Mnolargearray") {
} else if (arg == "-flarge-sizes") { } else if (arg == "-flarge-sizes") {
defaultKinds.set_sizeIntegerKind(8); defaultKinds.set_sizeIntegerKind(8);
} else if (arg == "-fno-large-sizes") { } else if (arg == "-fno-large-sizes") {
defaultKinds.set_sizeIntegerKind(4); defaultKinds.set_sizeIntegerKind(4);
} else if (arg == "-module") { } else if (arg == "-module") {
driver.moduleDirectory = args.front(); driver.moduleDirectory = args.front();
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines