This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Fix trying to widen <3 x s1> boolean ops
ClosedPublic

Authored by arsenm on Jul 20 2020, 5:34 AM.

Diff Detail

Event Timeline

arsenm created this revision.Jul 20 2020, 5:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2020, 5:34 AM
foad added inline comments.Jul 20 2020, 5:46 AM
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
66

Perhaps add a comment that "small" doesn't include s1 here?

76

getSizeInBits will be (an odd number) * (a number less than 32), so I don't think it can ever be a multiple of 32. But I suppose it's harmless.

arsenm updated this revision to Diff 279215.Jul 20 2020, 6:04 AM

Add comment

kerbowa accepted this revision.Aug 5 2020, 8:06 PM

LGTM

This revision is now accepted and ready to land.Aug 5 2020, 8:06 PM