This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Add proper testing for the SHT_MIPS_ABIFLAGS section.
ClosedPublic

Authored by grimar on Jul 16 2020, 8:22 AM.

Details

Summary

This rewrites the mips-abiflags.test to stop using recompiled objects,
adds testing for all missed bits and also adds two missing enum values
to lib/ObjectYAML, which are used in the new test.

Diff Detail

Event Timeline

grimar created this revision.Jul 16 2020, 8:22 AM
This revision is now accepted and ready to land.Jul 16 2020, 1:27 PM
MaskRay accepted this revision.Jul 16 2020, 2:40 PM

LGTM.

(not going to bother looking at the core of the change, since @MaskRay and @atanasyan have done so)

llvm/test/tools/llvm-readobj/ELF/mips-abiflags.test
74–75

"Document we do not report warnings for any version."

This revision was automatically updated to reflect the committed changes.