This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Try to promote to use packed saturating add/sub
ClosedPublic

Authored by arsenm on Jul 15 2020, 10:58 AM.

Details

Summary

This produces worse results right now for i8 vectors, but that should
be addressed when we actually try to optimize packed vectors.

Diff Detail

Event Timeline

arsenm created this revision.Jul 15 2020, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2020, 10:58 AM
foad added a comment.Aug 6 2020, 2:46 AM

Looks OK technically, but...

This produces worse results right now for i8 vectors

So is there any benefit to committing this now?

arsenm added a comment.Aug 6 2020, 6:44 AM

Looks OK technically, but...

This produces worse results right now for i8 vectors

So is there any benefit to committing this now?

So I don't have another random patch hanging around to handle this one obscure case that I'm sure will get forgotten. This isn't a unique problem, all of the code that legalizes to packed operations is garbage until we have some vector and bit op combines

foad accepted this revision.Aug 6 2020, 6:47 AM
This revision is now accepted and ready to land.Aug 6 2020, 6:47 AM