This is an archive of the discontinued LLVM Phabricator instance.

[NFC][RISCV] Test for D81805
ClosedPublic

Authored by rogfer01 on Jul 14 2020, 12:35 AM.

Details

Summary

This test is meant to show the codegen change once D81805 lands.

This has been reduced using bugpoint from regstack-1.c of the GCC Torture Suite. Thanks @asb for the suggestion on using this test.

Diff Detail

Event Timeline

rogfer01 created this revision.Jul 14 2020, 12:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2020, 12:35 AM

Are we sure we want to branch on undef to one of two unreachables?

I suppose we cannot use ret as we don't have a non-constant to return anyway.

Given this shows a change in the behaviour of D81805, I'm happy for this to land.

Are we sure we want to branch on undef to one of two unreachables?

I suppose we cannot use ret as we don't have a non-constant to return anyway.

Given this shows a change in the behaviour of D81805, I'm happy for this to land.

Good point. Let me check if I can get rid of that.

rogfer01 updated this revision to Diff 277762.Jul 14 2020, 3:34 AM

ChangeLog:

  • Remove dubious branch using undef. Use a plain ret void instead.
lenary accepted this revision.Jul 14 2020, 4:10 AM

LGTM

This revision is now accepted and ready to land.Jul 14 2020, 4:10 AM
This revision was automatically updated to reflect the committed changes.