This is an archive of the discontinued LLVM Phabricator instance.

Differential D83735

[MLIR] [TableGen] Avoid generating an assert which is always true.
ClosedPublic

Authored by jurahul on Jul 13 2020, 6:54 PM.

Details

Reviewers
jpienaar
rriddle
mehdi_amini
Commits
rG256d44811eab: [MLIR] [TableGen] Avoid generating an assert which is always true.
Summary
  • Avoid generating "assert(resultTypes.size() >= 0u)" which is always true

Diff Detail

Event Timeline

jurahul created this revision.Jul 13 2020, 6:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 6:54 PM
Herald added subscribers: msifontes, Kayjukh, grosul1 and 13 others. · View Herald Transcript
jurahul added reviewers: jpienaar, rriddle.Jul 13 2020, 6:55 PM
Harbormaster completed remote builds in B64085: Diff 277636.Jul 13 2020, 7:11 PM
mehdi_amini accepted this revision.Jul 13 2020, 9:50 PM
This revision is now accepted and ready to land.Jul 13 2020, 9:50 PM
Closed by commit rG256d44811eab: [MLIR] [TableGen] Avoid generating an assert which is always true. (authored by jurahul). · Explain WhyJul 14 2020, 9:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
tools/
mlir-tblgen/
20 lines

Diff 277636

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Show First 20 Lines • Show All 937 Lines • ▼ Show 20 Lines auto emit = [&](AttrParamKind attrType, TypeParamKind paramKind,
case TypeParamKind::Separate: case TypeParamKind::Separate:
for (int i = 0, e = op.getNumResults(); i < e; ++i) { for (int i = 0, e = op.getNumResults(); i < e; ++i) {
if (op.getResult(i).isOptional()) if (op.getResult(i).isOptional())
body << " if (" << resultNames[i] << ")\n "; body << " if (" << resultNames[i] << ")\n ";
body << " " << builderOpState << ".addTypes(" << resultNames[i] body << " " << builderOpState << ".addTypes(" << resultNames[i]
<< ");\n"; << ");\n";
} }
return; return;
case TypeParamKind::Collective: case TypeParamKind::Collective: {
int numResults = op.getNumResults();
int numVariadicResults = op.getNumVariableLengthResults();
int numNonVariadicResults = numResults - numVariadicResults;
bool hasVariadicResult = numVariadicResults != 0;
// Avoid emitting "resultTypes.size() >= 0u" which is always true.
if (!(hasVariadicResult && numNonVariadicResults == 0))
body << " " body << " "
<< "assert(resultTypes.size() " << "assert(resultTypes.size() "
<< (op.getNumVariableLengthResults() == 0 ? "==" : ">=") << " " << (hasVariadicResult ? ">=" : "==") << " "
<< (op.getNumResults() - op.getNumVariableLengthResults()) << numNonVariadicResults
<< "u && \"mismatched number of results\");\n"; << "u && \"mismatched number of results\");\n";
body << " " << builderOpState << ".addTypes(resultTypes);\n"; body << " " << builderOpState << ".addTypes(resultTypes);\n";
}
return; return;
} }
llvm_unreachable("unhandled TypeParamKind"); llvm_unreachable("unhandled TypeParamKind");
}; };
for (auto attrType : attrBuilderType) { for (auto attrType : attrBuilderType) {
emit(attrType, TypeParamKind::Separate, /*inferType=*/false); emit(attrType, TypeParamKind::Separate, /*inferType=*/false);
if (canInferType(op)) if (canInferType(op))
▲ Show 20 Lines • Show All 1,229 Lines • Show Last 20 Lines