Page MenuHomePhabricator
Differential D83735

[MLIR] [TableGen] Avoid generating an assert which is always true.
ClosedPublic
Actions

Authored by jurahul on Jul 13 2020, 6:54 PM.

Details

Reviewers
jpienaar
rriddle
mehdi_amini
Commits
rG256d44811eab: [MLIR] [TableGen] Avoid generating an assert which is always true.
Summary
  • Avoid generating "assert(resultTypes.size() >= 0u)" which is always true

Diff Detail

Event Timeline

jurahul created this revision.Jul 13 2020, 6:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 6:54 PM
Herald added subscribers: msifontes, Kayjukh, grosul1 and 13 others. · View Herald Transcript
jurahul added reviewers: jpienaar, rriddle.Jul 13 2020, 6:55 PM
Harbormaster completed remote builds in B64085: Diff 277636.Jul 13 2020, 7:11 PM
mehdi_amini accepted this revision.Jul 13 2020, 9:50 PM
This revision is now accepted and ready to land.Jul 13 2020, 9:50 PM
Closed by commit rG256d44811eab: [MLIR] [TableGen] Avoid generating an assert which is always true. (authored by jurahul). · Explain WhyJul 14 2020, 9:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
tools/
mlir-tblgen/
20 lines

Diff 277867

View Options

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Loading...