This is exposed by https://reviews.llvm.org/D83486.
When the host is UTF8, we may get n >10, causing assert failure.
Increase the buffersize to support UTF-8 to C conversion.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Could you please explain why D83486 broke this test and what does PowerPC have to do with it? I’m just curious.
Ah, and thanks for fixing the issue!
Comment Actions
Actually, it has nothing to do with PowerPC, just happens on our bots.
D83486 change the lit test env, to use parent process env, which include locale setting, and our PowerPC bots have UTF-8 locale by default,
so when we call newlocale in this test, we get UTF-8 locale instead of C locale.
So when we call strxfrm_l we get n =20 > 10, so the tests assert in line 19..