This introduces new flag to the update_test_checks that allows for
function attributes to be checked in a check-line. If the flag is not,
the behavior should remain the same.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
This is great, thanks! We'll have to update all the Attributor tests now :D
LGTM, one minor request below.
llvm/utils/UpdateTestChecks/common.py | ||
---|---|---|
394 | Nit: Maybe add the ; too. | |
llvm/utils/update_test_checks.py | ||
56 | Can we add this to the _cc_test script too (with test). Seems useful when you come from C as well. |
llvm/utils/update_test_checks.py | ||
---|---|---|
56 | Sure. One concern though. I think this would require running the test with at least -O1 and -attributor-enable flags. |
llvm/utils/update_test_checks.py | ||
---|---|---|
56 | Why would that test require attributor? |
llvm/utils/update_test_checks.py | ||
---|---|---|
56 | Ok, makes sense. Will do that. |
Nit: Maybe add the ; too.