Page MenuHomePhabricator

[analyzer] Fix ctu-on-demand-parsing: REQUIRES: linux -> REQUIRES: system-linux
ClosedPublic

Authored by steakhal on Jul 10 2020, 6:51 AM.

Details

Summary

AFAIK there is no such feature as linux.
I think this should be system-linux

linux and freebsd requirement tags were used by other projects like XRay.
I'm not sure if those tests are skipped or not. I would really appreciate any feedback on this.

The relevant test infra code segment is this - I think:
https://github.com/llvm/llvm-project/blob/master/llvm/utils/lit/lit/llvm/config.py#L54-L55

elif platform.system() == 'Linux':
    features.add('system-linux')

BTW on my system (Ubuntu 18.04), the patched tests were marked UNSUPPORTED.
After the fix, they all PASSed.

Diff Detail

Event Timeline

steakhal created this revision.Jul 10 2020, 6:51 AM
gamesh411 accepted this revision.Jul 10 2020, 6:58 AM

Good thing you were looking inside the test infra code to catch this, kudos!

This revision is now accepted and ready to land.Jul 10 2020, 6:58 AM

In addition, IMHO the test infra should then be extended to throw an exception, when a feature is referenced that is not mentioned anywhere. That would be helpful in the future.

martong accepted this revision.Jul 10 2020, 7:36 AM

Thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 5:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript