Page MenuHomePhabricator

AMDGPU/GlobalISel: Handle call return values
ClosedPublic

Authored by arsenm on Jul 7 2020, 9:57 AM.

Details

Summary

The only case that I know doesn't work is the implicit sret case when
the return type doesn't fit in the return registers.

Diff Detail

Event Timeline

arsenm created this revision.Jul 7 2020, 9:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2020, 9:57 AM
kerbowa accepted this revision.Jul 23 2020, 1:20 AM

LGTM

llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-call-return-values.ll
457

Should this be sext?

This revision is now accepted and ready to land.Jul 23 2020, 1:20 AM
arsenm marked an inline comment as done.Jul 23 2020, 10:54 AM
arsenm added inline comments.
llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-call-return-values.ll
457

it's not really important but it could be