[DWARFYAML] Refactor: Pull out member functions to DWARFYAMLUtils.cpp.

[Higuoxing]

Summary

DWARFYAML.cpp should only hold functions for mapping YAML representation
to DWARF structures.

In this change, I add a file DWARFYAMLUtils.cpp to contain helper
functions that are defined as member functions. In the future, we will
add some helper functions that make DWARF sections interlinked. They
should be implemented in DWARFYAMLUtils.cpp.

[grimar]

So, currently, for example, DWARFYAML::Data is defined in DWARFYAML.h
(https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/ObjectYAML/DWARFYAML.h#L180) and implemented in DWARFYAML.cpp.

With this change the implementation of members is moved to a new DWARFYAMLUtils.cpp file. I.e. we have DWARFYAML.h + DWARFYAMLUtils.cpp with this patch.
Honestly, it looks a bit unnatural to me, because it breaks the straightforward common approach: "define in a header, implement in a cpp with the same name".

You're saying that "In the future, we will add some helper functions that make DWARF sections interlinked". Perhaps I'd wait for these functions to appear and may be
then create DWARFYAMLUtils.h + DWARFYAMLUtils.cpp for them.

[Higuoxing]

In D83282#2135231, @grimar wrote:

So, currently, for example, DWARFYAML::Data is defined in DWARFYAML.h
(https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/ObjectYAML/DWARFYAML.h#L180) and implemented in DWARFYAML.cpp.

With this change the implementation of members is moved to a new DWARFYAMLUtils.cpp file. I.e. we have DWARFYAML.h + DWARFYAMLUtils.cpp with this patch.
Honestly, it looks a bit unnatural to me, because it breaks the straightforward common approach: "define in a header, implement in a cpp with the same name".

You're saying that "In the future, we will add some helper functions that make DWARF sections interlinked". Perhaps I'd wait for these functions to appear and may be
then create DWARFYAMLUtils.h + DWARFYAMLUtils.cpp for them.

Sure, I will upload them later to see how it works, thanks for the suggestion!

llvm/lib/ObjectYAML/CMakeLists.txt

 add_llvm_component_library(LLVMObjectYAML
   CodeViewYAMLDebugSections.cpp
   CodeViewYAMLSymbols.cpp
   CodeViewYAMLTypeHashing.cpp
   CodeViewYAMLTypes.cpp
   COFFEmitter.cpp
   COFFYAML.cpp
   DWARFEmitter.cpp
   DWARFVisitor.cpp
   DWARFYAML.cpp
+  DWARFYAMLUtils.cpp
   ELFEmitter.cpp
   ELFYAML.cpp
   MachOEmitter.cpp
   MachOYAML.cpp
   ObjectYAML.cpp
   MinidumpEmitter.cpp
   MinidumpYAML.cpp
   WasmEmitter.cpp
   WasmYAML.cpp
   XCOFFYAML.cpp
   YAML.cpp
   yaml2obj.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${LLVM_MAIN_INCLUDE_DIR}/llvm/ObjectYAML
   )

llvm/lib/ObjectYAML/DWARFYAML.cpp

 //
 //===----------------------------------------------------------------------===//
 
 #include "llvm/ObjectYAML/DWARFYAML.h"
 #include "llvm/BinaryFormat/Dwarf.h"
 
 namespace llvm {
 
-bool DWARFYAML::Data::isEmpty() const {
-  return DebugStrings.empty() && AbbrevDecls.empty() && ARanges.empty() &&
-         DebugRanges.empty() && !PubNames && !PubTypes && !GNUPubNames &&
-         !GNUPubTypes && CompileUnits.empty() && DebugLines.empty();
-}
-
-SetVector<StringRef> DWARFYAML::Data::getUsedSectionNames() const {
-  SetVector<StringRef> SecNames;
-  if (!DebugStrings.empty())
-    SecNames.insert("debug_str");
-  if (!ARanges.empty())
-    SecNames.insert("debug_aranges");
-  if (!DebugRanges.empty())
-    SecNames.insert("debug_ranges");
-  if (!DebugLines.empty())
-    SecNames.insert("debug_line");
-  if (!DebugAddr.empty())
-    SecNames.insert("debug_addr");
-  if (!AbbrevDecls.empty())
-    SecNames.insert("debug_abbrev");
-  if (!CompileUnits.empty())
-    SecNames.insert("debug_info");
-  if (PubNames)
-    SecNames.insert("debug_pubnames");
-  if (PubTypes)
-    SecNames.insert("debug_pubtypes");
-  if (GNUPubNames)
-    SecNames.insert("debug_gnu_pubnames");
-  if (GNUPubTypes)
-    SecNames.insert("debug_gnu_pubtypes");
-  return SecNames;
-}
-
 namespace yaml {
 
 void MappingTraits<DWARFYAML::Data>::mapping(IO &IO, DWARFYAML::Data &DWARF) {
   void *OldContext = IO.getContext();
   DWARFYAML::DWARFContext DWARFCtx;
   IO.setContext(&DWARFCtx);
   IO.mapOptional("debug_str", DWARF.DebugStrings);
   IO.mapOptional("debug_abbrev", DWARF.AbbrevDecls);

llvm/lib/ObjectYAML/DWARFYAMLUtils.cpp

+//===- DWARFYAMLUtils.cpp - -------------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+/// \file
+/// This file contains implementations for member functions in DWARFYAML.
+//===----------------------------------------------------------------------===//
+
+#include "llvm/ADT/SetVector.h"
+#include "llvm/ObjectYAML/DWARFYAML.h"
+
+namespace llvm {
+
+bool DWARFYAML::Data::isEmpty() const {
+  return DebugStrings.empty() && AbbrevDecls.empty() && ARanges.empty() &&
+         DebugRanges.empty() && !PubNames && !PubTypes && !GNUPubNames &&
+         !GNUPubTypes && CompileUnits.empty() && DebugLines.empty();
+}
+
+SetVector<StringRef> DWARFYAML::Data::getUsedSectionNames() const {
+  SetVector<StringRef> SecNames;
+  if (!DebugStrings.empty())
+    SecNames.insert("debug_str");
+  if (!ARanges.empty())
+    SecNames.insert("debug_aranges");
+  if (!DebugRanges.empty())
+    SecNames.insert("debug_ranges");
+  if (!DebugLines.empty())
+    SecNames.insert("debug_line");
+  if (!DebugAddr.empty())
+    SecNames.insert("debug_addr");
+  if (!AbbrevDecls.empty())
+    SecNames.insert("debug_abbrev");
+  if (!CompileUnits.empty())
+    SecNames.insert("debug_info");
+  if (PubNames)
+    SecNames.insert("debug_pubnames");
+  if (PubTypes)
+    SecNames.insert("debug_pubtypes");
+  if (GNUPubNames)
+    SecNames.insert("debug_gnu_pubnames");
+  if (GNUPubTypes)
+    SecNames.insert("debug_gnu_pubtypes");
+  return SecNames;
+}
+
+} // end namespace llvm