Page MenuHomePhabricator
Differential D82933

[DWARFYAML][debug_abbrev] Emit 0 byte for terminating abbreviations.
ClosedPublic
Actions

Authored by Higuoxing on Jun 30 2020, 11:33 PM.

Details

Reviewers
jhenderson
grimar
MaskRay
• espindola
Commits
rG38907b696c0e: [DWARFYAML][debug_abbrev] Emit 0 byte for terminating abbreviations.
Summary

The abbreviations for a given compilation unit end with an entry
consisting of a 0 byte for the abbreviation code.

Diff Detail

Unit TestsFailed
View All

TimeTest
6,290 mslinux > libomp.env::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/env/kmp_set_dispatch_buf.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/env/Output/kmp_set_dispatch_buf.c.tmp -lm -latomic && env KMP_DISP_NUM_BUFFERS=0 /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/env/Output/kmp_set_dispatch_buf.c.tmp
1,590 mslinux > libomp.worksharing/for::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/worksharing/for/kmp_set_dispatch_buf.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/worksharing/for/Output/kmp_set_dispatch_buf.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/worksharing/for/Output/kmp_set_dispatch_buf.c.tmp 7

Event Timeline

Higuoxing created this revision.Jun 30 2020, 11:33 PM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 30 2020, 11:33 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, hiraditya, emaste. · View Herald Transcript
Harbormaster failed remote builds in B62454: Diff 274687!Jul 1 2020, 1:02 AM
jhenderson accepted this revision.Jul 1 2020, 2:12 AM

LGTM, with on suggestion.

llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml
46–47

How about "attr terminator" and "abbrev terminator".

This revision is now accepted and ready to land.Jul 1 2020, 2:12 AM
Higuoxing updated this revision to Diff 274821.Jul 1 2020, 8:15 AM
Higuoxing marked an inline comment as done.

Address comment.

Closed by commit rG38907b696c0e: [DWARFYAML][debug_abbrev] Emit 0 byte for terminating abbreviations. (authored by Higuoxing). · Explain WhyJul 1 2020, 9:10 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B62517: Diff 274821!Jul 1 2020, 9:42 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
ObjectYAML/
4 lines
test/
ObjectYAML/
MachO/
4 lines
tools/
yaml2obj/
ELF/
DWARF/
17 lines
4 lines

Diff 274821

View Options

llvm/lib/ObjectYAML/DWARFEmitter.cpp

Loading...
View Options

llvm/test/ObjectYAML/MachO/DWARF2-AddrSize8-FormValues.yaml

Loading...
View Options

llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml

Loading...
View Options

llvm/test/tools/yaml2obj/ELF/DWARF/debug-info.yaml

Loading...