Page MenuHomePhabricator

[DWARFYAML][debug_abbrev] Emit 0 byte for terminating abbreviations.
ClosedPublic

Authored by Higuoxing on Jun 30 2020, 11:33 PM.

Details

Summary

The abbreviations for a given compilation unit end with an entry
consisting of a 0 byte for the abbreviation code.

Diff Detail

Event Timeline

Higuoxing created this revision.Jun 30 2020, 11:33 PM
Herald added a project: Restricted Project. · View Herald Transcript
jhenderson accepted this revision.Jul 1 2020, 2:12 AM

LGTM, with on suggestion.

llvm/test/tools/yaml2obj/ELF/DWARF/debug-abbrev.yaml
46–47

How about "attr terminator" and "abbrev terminator".

This revision is now accepted and ready to land.Jul 1 2020, 2:12 AM
Higuoxing updated this revision to Diff 274821.Jul 1 2020, 8:15 AM
Higuoxing marked an inline comment as done.

Address comment.

This revision was automatically updated to reflect the committed changes.