This patch exploits the VSX Vector Splat Immediate Word and VSX Vector Splat Immediate Double Precision Instructions:
xxspltiw XT,IMM32 xxspltidp XT,IMM32
Depends on D82896.
Paths
| Differential D82911
[PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions. ClosedPublic Authored by lei on Jun 30 2020, 1:20 PM.
Details
Summary This patch exploits the VSX Vector Splat Immediate Word and VSX Vector Splat Immediate Double Precision Instructions: xxspltiw XT,IMM32 xxspltidp XT,IMM32 Depends on D82896.
Diff Detail
Event Timeline
Comment Actions Updated the patch:
amyk added inline comments.
Comment Actions Updated the patch:
Comment Actions
NeHuang added inline comments.
lei marked 4 inline comments as done. Comment ActionsRemove unnecessary FIXME message, accidental formating, and simplify if-condition as suggested by Victor.
This revision is now accepted and ready to land.Jul 1 2020, 12:42 PM Comment Actions LGTM.
lei marked an inline comment as done. Comment Actionsrename test file and add additional ccomments to code. Closed by commit rGc5b4f03b53a4: [PowerPC] Exploit xxspltiw and xxspltidp instructions (authored by anil9, committed by lei). · Explain WhyJul 1 2020, 5:22 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 274969 llvm/lib/Target/PowerPC/PPCISelLowering.h
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/lib/Target/PowerPC/PPCInstrInfo.td
llvm/lib/Target/PowerPC/PPCInstrPrefix.td
llvm/test/CodeGen/PowerPC/p10-splatImm-CPload-pcrel.ll
llvm/test/CodeGen/PowerPC/p10-splatImm.ll
|
Any reason why we are not following the format used for the other case statements?
If it fit within 1 line, it would be good to match the formate of this switch stmt.